Enable xlf for dotnet build by adding reference to XliffTasks package #16327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Version should be declared in xml file like with other package versions (Versions.prop under eng). Also, that should be guarded to only run when not under arcade (to avoid conflicts with arcade itself). |
|
Ok, I added the guard, will move the version |
|
Version should likely be |
|
CoreCLR issue is transient, it happens sometimes, should go away once we update on stable .NET8 |
T-Gro
approved these changes
Nov 24, 2023
edgarfgp
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #16311
It seems what is missing is just a reference to the XliffTasks package.
I am not sure about the version though (and was not able to list available versions).