Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StackOverflow in big-ish nested CEs #17002

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Conversation

vzarytovskii
Copy link
Member

@vzarytovskii vzarytovskii commented Apr 8, 2024

Fixes SO in CE's like below:

module Testing

let test () =
    task {
            let c1 = failwith ""
            let c2 = failwith ""
            let c3 = failwith ""
            let c4 = failwith ""
            let c5 = failwith ""
            let c6 = failwith ""
            let c7 = failwith ""
            let c8 = failwith ""
            let c8 = failwith ""
            let c10 = failwith ""
            let c11 = failwith ""
            let c12 = failwith ""
            let c13 = failwith ""
            let c14 = failwith ""
            let c15 = failwith ""
            let c16 = failwith ""
            let c17 = failwith ""
            let c18 = failwith ""
            let c19 = failwith ""
            let c20 = failwith ""
            let c21 = failwith ""
            let c22 = failwith ""
            let c23 = failwith ""
            let c24 = failwith ""
            let c25 = failwith ""
            let c26 = failwith ""
            let c27 = failwith ""
            let c28 = failwith ""
            let c29 = failwith ""
            let c30 = failwith ""
            let c31 = failwith ""
            let c32 = failwith ""
            let c33 = failwith ""
            let c34 = failwith ""
            let c35 = failwith ""
            let c36 = failwith ""
            let c37 = failwith ""
            let c38 = failwith ""
            let c39 = failwith ""
            let c40 = failwith ""
            let c41 = failwith ""
            let c42 = failwith ""
            let c43 = failwith ""
            let c44 = failwith ""
            let c45 = failwith ""
            let c46 = failwith ""
            let c47 = failwith ""
            let c48 = failwith ""
            let c49 = failwith ""
            let c50 = failwith ""
            let c51 = failwith ""
            let c52 = failwith ""
            let c53 = failwith ""
            let c54 = failwith ""
            let c55 = failwith ""
            let c56 = failwith ""
            let c57 = failwith ""
            let c58 = failwith ""
            let c59 = failwith ""
            let c60 = failwith ""
            let c61 = failwith ""
            let c62 = failwith ""
            let c63 = failwith ""
            let c64 = failwith ""
            let c65 = failwith ""
            let c66 = failwith ""
            let c67 = failwith ""
            let c68 = failwith ""
            let c69 = failwith ""
            ()
    }

[<EntryPoint>]
let main _ =
    test () |> ignore
    printfn "Hello, World!"
    0

Not going to add any tests for it probably, it's a quick fix I'm making from browser to unblock myself from some resumable code experiments (+ have a fix separately from my branch, since it will also be beneficial in upstream), anyone else is welcome to add some though.

@vzarytovskii vzarytovskii added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Apr 8, 2024
@vzarytovskii vzarytovskii requested a review from a team as a code owner April 8, 2024 13:38
Copy link
Contributor

github-actions bot commented Apr 8, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@vzarytovskii
Copy link
Member Author

/run fantomas

  Co-authored-by: vzarytovskii <[email protected]>
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants