Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MEF issues with options #17015

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Fix MEF issues with options #17015

merged 1 commit into from
Apr 11, 2024

Conversation

vzarytovskii
Copy link
Member

@vzarytovskii vzarytovskii commented Apr 10, 2024 •
edited
Loading

Fixes #16965
It seems something changed about MEF import w.r.t. private members. @KevinRansom are we building VSIX with real signatures now by any chance?

Will appreciate confirmation whether it fixes the issue or not.

@vzarytovskii
Fix MEF issues with options
04e0214 
It seems something changed about MEF import w.r.t. private members.
@vzarytovskii vzarytovskii added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Apr 10, 2024
@vzarytovskii vzarytovskii requested a review from a team as a code owner April 10, 2024 13:21
@vzarytovskii vzarytovskii linked an issue Apr 10, 2024 that may be closed by this pull request
VS: crash or hang when accessing F# Text Editor options #16965
Closed
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@majocha
Copy link
Contributor

majocha commented Apr 10, 2024

I can confirm this fixes it. Nice!

@vzarytovskii
Copy link
Member Author

Well, that confuses me even more. It's either default MEF behaviour has changed, or we use realsig in the VSIX.

@T-Gro
Copy link
Member

T-Gro commented Apr 10, 2024

Tested a few times.

Settings window was crashing for me.
On this PR, it never does.

@TIHan
Copy link
Contributor

TIHan commented Apr 10, 2024

I remember MEF...

@vzarytovskii
Copy link
Member Author

Might be mix of realsig + optimizer, since it's
A. Doesn't fail while debugging vsix
B. Is exported via private property which isn't used anywhere.

Might be, due to new codegen, optimized away in release build.

@vzarytovskii vzarytovskii merged commit 3c8490c into main Apr 11, 2024
33 checks passed
@vzarytovskii
Copy link
Member Author

/backport to release/dev17.10

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/dev17.10: https://github.com/dotnet/fsharp/actions/runs/8645556492

@github-actions github-actions bot mentioned this pull request Apr 11, 2024
Merged
This was referenced Apr 17, 2024
Closed
Closed
@vzarytovskii vzarytovskii mentioned this pull request Aug 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinRansom KevinRansom KevinRansom requested changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VS: crash or hang when accessing F# Text Editor options
5 participants
@vzarytovskii @majocha @T-Gro @TIHan @KevinRansom