reset realsig for release/dev10.0 #17022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
|
/cc @vzarytovskii -- here you go mate. |
abonie
approved these changes
Apr 10, 2024
vzarytovskii
approved these changes
Apr 10, 2024
|
FWIW I went through all the exports in |
|
@majocha me too, but we prefer to minimize the risk. |
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some places in the VS code where we Export private values to MEF. This causes some issues when compiled with --realsig+ because the shipping existing FSharp compiler promotes them to internal.
This PR temporarily builds with --realsig- so that we can audit the codebase to eliminate those private exports and re-enable realsig .