Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for CLIMutableAttribute when checking attribute targets #17559

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

edgarfgp
Copy link
Contributor

Description

CLIMutableAttribute has a special treatment(specific error FS3132) in the case of records(Only record types may have this attribute.)

So we want to keep these special treatment for records and avoid having two errors for the same attribute.

Checklist

  • Test cases added
  • Release notes entry updated

@edgarfgp edgarfgp changed the title Account for CLIMutableAttribute when checking attribute targets Account for CLIMutableAttribute when checking attribute targets Aug 18, 2024
@edgarfgp edgarfgp added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 18, 2024
Copy link
Contributor

github-actions bot commented Aug 18, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@edgarfgp edgarfgp force-pushed the cli-mutable-attributes-tests branch from 308fb9c to d313e68 Compare August 18, 2024 13:34
@edgarfgp edgarfgp marked this pull request as ready for review August 18, 2024 15:29
@edgarfgp edgarfgp requested a review from a team as a code owner August 18, 2024 15:29
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KevinRansom
Copy link
Member

There are other cases where the attribute change has doubled up on error messages. We should probably spend the effort to go through the attribute errors and see where else we can reduce doubled up errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants