Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for VolatileAttribute when checking attribute targets #17595

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Account for VolatileAttribute when checking attribute targets #17595

merged 5 commits into from
Aug 26, 2024

Conversation

edgarfgp
Copy link
Contributor

Description

Account for VolatileAttribute when checking attribute targets on let binding classes

Fixes # (issue, if applicable)

Checklist

  • Test cases added
  • Release notes entry updated

@edgarfgp edgarfgp added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 23, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@edgarfgp edgarfgp marked this pull request as ready for review August 23, 2024 16:05
@edgarfgp edgarfgp requested a review from a team as a code owner August 23, 2024 16:05
@edgarfgp edgarfgp closed this Aug 25, 2024
@edgarfgp edgarfgp reopened this Aug 25, 2024
@T-Gro T-Gro enabled auto-merge (squash) August 26, 2024 08:50
auto-merge was automatically disabled August 26, 2024 12:54

Head branch was pushed to by a user without write access

psfinaki
psfinaki approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks for the contribution :)

@psfinaki psfinaki merged commit c8fbed0 into dotnet:main Aug 26, 2024
30 checks passed
This was referenced Aug 28, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Sep 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@psfinaki psfinaki psfinaki approved these changes

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edgarfgp @psfinaki @T-Gro @KevinRansom