Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error output in tests #18097

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fix error output in tests #18097

merged 2 commits into from
Dec 3, 2024

Conversation

vzarytovskii
Copy link
Member

Not certain what has happened, used to work in the past.

Before:
image

After:
image

@vzarytovskii vzarytovskii requested a review from a team as a code owner December 2, 2024 14:57
@vzarytovskii vzarytovskii added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@majocha
Copy link
Contributor

majocha commented Dec 2, 2024

Sorry, my bad. This sneaked in from my parallel testing PR. Unlike there, eprintfn here on main is not wired up to xUnit output.

@vzarytovskii vzarytovskii enabled auto-merge (squash) December 2, 2024 16:49
@vzarytovskii vzarytovskii merged commit a94990b into dotnet:main Dec 3, 2024
33 checks passed
This was referenced Dec 13, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@psfinaki psfinaki psfinaki approved these changes

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vzarytovskii @majocha @psfinaki @T-Gro