Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing type constraints in FCS #18241

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Added missing type constraints in FCS #18241

merged 4 commits into from
Jan 20, 2025

Conversation

ncave
Copy link
Contributor

@ncave ncave commented Jan 16, 2025

  • Exposes missing type constraints in FCS

@ncave ncave requested a review from a team as a code owner January 16, 2025 15:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

@T-Gro T-Gro enabled auto-merge (squash) January 17, 2025 10:28
@psfinaki
Copy link
Member

Hi @ncave - thanks for the contribution! This is almost good to go, please fill in the release notes and also please run ILVerify locally to update the baselines, as per these instructions.

Shout out if you need any help.

@ncave ncave changed the title Expose missing type constraints in FCS Added missing type constraints in FCS Jan 17, 2025
auto-merge was automatically disabled January 17, 2025 15:45

Head branch was pushed to by a user without write access

@ncave
Copy link
Contributor Author

ncave commented Jan 17, 2025

@psfinaki I updated the release notes for 9.0.300, but let me know if there is still a chance to make 9.0.200, and I can move it.

@vzarytovskii
Copy link
Member

@psfinaki I updated the release notes for 9.0.300, but let me know if there is still a chance to make 9.0.200, and I can move it.

9.0.200 is done by now, unfortunately.

@psfinaki psfinaki merged commit 72ab794 into dotnet:main Jan 20, 2025
33 checks passed
@ncave ncave deleted the temp3 branch January 20, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncave @psfinaki @vzarytovskii @T-Gro