Bugfix :: Flexible types should subsume nullable version of equivalent CoarcesTo constraints #18266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
…ning-with-flexible-type
T-Gro
changed the title
❗ Release notes required
|
psfinaki
approved these changes
Feb 4, 2025
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
0101
approved these changes
Feb 4, 2025
T-Gro
deleted the
18056-nullness-issue---spurious-nullness-warning-with-flexible-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18056
When using
#IDisposable, it should subsume any nullable as well as non-nullable version of the head types (following the inheritance hiearchy).When using
#IDisposable | nullas the flexible type, it should subsume nullable versions of any of the types in the hierarchy, and warn on when passed to non-nullable parameters.Before this fix, a warning was always emitted from an internal compiler call to enforce constraint consistency.