Replace internal option–voption conversions with FSharp.Core funcs #18269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
T-Gro
added
the
NO_RELEASE_NOTES
T-Gro
approved these changes
Jan 27, 2025
kerams
reviewed
Jan 27, 2025
Comment on lines
3527
to
+3530
| [<return: Struct>] | ||
| let (|ExtractAttribNamedArg|_|) nm args = | ||
| args |> List.tryPick (function AttribNamedArg(nm2, _, _, v) when nm = nm2 -> Some v | _ -> None) |> ValueOptionInternal.ofOption | ||
| args |> List.tryPick (function AttribNamedArg(nm2, _, _, v) when nm = nm2 -> Some v | _ -> None) |> ValueOption.ofOption | ||
|
|
There was a problem hiding this comment.
Off topic, but what is the point of this AP returning voption when option is still being created? Doesn't the conversion do nothing but add overhead?
There was a problem hiding this comment.
Yes.
A tryPickV equivalent would be better here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reprise of #17457, now that FSharp.Core 9 has shipped.
'T option↔'T voption#17436.Resolves #17460.
Checklist