Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancellable: only cancel on OCE with own token #18277

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Cancellable: only cancel on OCE with own token #18277

merged 4 commits into from
Jan 29, 2025

Conversation

auduchinok
Copy link
Member

I think Cancellable should only cancel when getting an OCE with its own cancellation token. When another token is encountered in such exception, it probably means something is not right.

@auduchinok auduchinok requested a review from a team as a code owner January 28, 2025 05:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

@T-Gro T-Gro enabled auto-merge (squash) January 28, 2025 13:49
@T-Gro T-Gro merged commit 58560f8 into dotnet:main Jan 29, 2025
33 checks passed
@auduchinok auduchinok deleted the cancellable-assertToken branch January 30, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@auduchinok @psfinaki @T-Gro