Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix add file reference (com dll) #281

Closed
wants to merge 3 commits into from

Conversation

enricosada
Copy link
Contributor

lcid is an integer
fix typelib registry path, the lcid part is the hexadecimal string representation of the lcid value
added exception on failed add reference
fix nre on if registry key not found

fix #278

lcid is an integer
fix typelib registry path, the lcid part is the hexadecimal string representation of the lcid value
added exception on failed add reference
fix nre on if registry key not found

fix dotnet#278
@latkin
Copy link
Contributor

latkin commented Feb 27, 2015

Is there an easy way to add an IDE unit test for this? If there are standard COM libs that trigger the issue it would be cool to have a test that validates "add reference" for one of those (assuming there is unit test support for the "add reference" action, maybe there isn't)

Edit: looks like some pretty good support in Tests.ProjectSystem.References.fs

@enricosada
Copy link
Contributor Author

maybe @lasandell can help us choose a suitable com class (he wrote the COM typeprovider ) or give a feedback about com status in vs extension or tests needed.
In the test they use COM.Microsoft Shell Controls And Automation.1.0.ShellClass

Thx @latkin i'll add a test like your hint

@enricosada
Copy link
Contributor Author

added test

@enricosada
Copy link
Contributor Author

the build failure is not related to this pr

Build execution time has reached the maximum allowed time for your plan (40 minutes)

latkin pushed a commit that referenced this pull request Mar 5, 2015
lcid is an integer
fix typelib registry path, the lcid part is the hexadecimal string representation of the lcid value
added exception on failed add reference
fix nre on if registry key not found

fixes #278
closes #281

commit 64185d2
Author: enricosada <[email protected]>
Date:   Tue Mar 3 21:45:40 2015 +0100

    add test

commit c4fb65d
Author: enricosada <[email protected]>
Date:   Fri Feb 27 19:31:29 2015 +0100

    remove unused try/catch

commit 4a05993
Author: enricosada <[email protected]>
Date:   Fri Feb 27 18:47:03 2015 +0100

    fix add file reference (com dll)

    lcid is an integer
    fix typelib registry path, the lcid part is the hexadecimal string representation of the lcid value
    added exception on failed add reference
    fix nre on if registry key not found

    fix #278
@latkin
Copy link
Contributor

latkin commented Mar 5, 2015

This is applied.

@latkin latkin closed this Mar 5, 2015
@latkin latkin added the fixed label Mar 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullReferenceException when trying to add some COM references
3 participants