Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't quote generic type parameters on rename #6491

Merged
merged 1 commit into from
Apr 16, 2019
Merged

Don't quote generic type parameters on rename #6491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion vsintegration/src/FSharp.Editor/InlineRename/InlineRenameService.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,11 @@ type internal InlineRenameLocationSet(locations: InlineRenameLocation [], origin

async {
let! newSolution = applyChanges originalSolution (locations |> Array.toList |> List.groupBy (fun x -> x.Document))
let replacementText =
match symbolKind with
| LexerSymbolKind.GenericTypeParameter
| LexerSymbolKind.StaticallyResolvedTypeParameter -> replacementText
| _ -> Lexhelp.Keywords.NormalizeIdentifierBackticks replacementText
return
{ new IInlineRenameReplacementInfo with
member __.NewSolution = newSolution
Expand Down Expand Up @@ -94,7 +99,7 @@ type internal InlineRenameInfo
member __.DisplayName = symbolUse.Symbol.DisplayName
member __.FullDisplayName = try symbolUse.Symbol.FullName with _ -> symbolUse.Symbol.DisplayName
member __.Glyph = Glyph.MethodPublic
member __.GetFinalSymbolName replacementText = Lexhelp.Keywords.NormalizeIdentifierBackticks replacementText
member __.GetFinalSymbolName replacementText = replacementText

member __.GetReferenceEditSpan(location, cancellationToken) =
let text = getDocumentText location.Document cancellationToken
Expand Down