Update VS tools version(s) to 10.7/F# 4.7 #8019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nope this won't fix that. Brett is working on fixing the codeflow into dev 16.5 previews. Fixing the version display for 16.5 has already been updated in the dev16.5 branch. The product version in 16.5 is currently set to 10.8 here However, it looks like we haven't parameterized the file correctly, and so we should fix that. |
|
And some more unparameterized invalid places, where I think the actual value comes from: I think that value is here: https://github.com/dotnet/fsharp/blob/release/dev16.5/vsintegration/src/FSharp.ProjectSystem.FSharp/VSPackage.resx#L467 and a few other places. We need to parameterize it I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably fixes #8018