Add Microsoft.DotNet.HotReload.Utils.Generator.BuildTool MSBuild target nuget #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from dotnet/arcade
The idea is that projects will be able to include ``` <PackageReference Include="Microsoft.DotNet.HotReload.Utils.Generator.BuildTool" Version="$(MicrosoftDotNetHotReloadUtilsVersion)" /> ``` And they will automatically get a task added to their build that will run the included version of the delta generator as part of their build. Right now the .targets file doesn't do anything except run the tool with `--help`
Seems to generate workable deltas now
|
FYI: @ViktorHofer you were right, adding a targets nuget wasn't too bad. Tried it locally, seems to be working. After I merge this and publish packages, I'll update the dotnet/runtime#51144 to use it |
ViktorHofer
reviewed
May 4, 2021
...Reload.Utils.Generator.BuildTool/Microsoft.DotNet.HotReload.Utils.Generator.BuildTool.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
May 4, 2021
...Reload.Utils.Generator.BuildTool/Microsoft.DotNet.HotReload.Utils.Generator.BuildTool.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
May 4, 2021
...Utils.Generator.BuildTool/build/Microsoft.DotNet.HotReload.Utils.Generator.BuildTool.targets
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
May 4, 2021
...Utils.Generator.BuildTool/build/Microsoft.DotNet.HotReload.Utils.Generator.BuildTool.targets
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
May 4, 2021
...otReload.Utils.Generator.Frontend/Microsoft.DotNet.HotReload.Utils.Generator.Frontend.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
May 4, 2021
ViktorHofer
reviewed
May 4, 2021
ViktorHofer
reviewed
May 4, 2021
ViktorHofer
reviewed
May 4, 2021
src/Microsoft.DotNet.HotReload.Utils.Generator.BuildTool/Program.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a nuget package that has a target that runs a copy of the delta generator right after a
Buildtarget.Factor out the common command-line frontend into a new Frontend assembly.