Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove no-cdn concept, remove azureedge links #564

Merged

Conversation

JanProvaznik
Copy link
Member

Fixes #563 #559

@JanProvaznik
Copy link
Member Author

dotnet/docs#44166

@leecow
Copy link
Member

leecow commented Jan 7, 2025

adjust this script to the changes
https://dotnetcli.blob.core.windows.net/dotnet/release/install-preview/install-dotnet-preview.sh

install-preview script has been updated.

@baronfel
Copy link
Member

baronfel commented Jan 9, 2025

@JanProvaznik any blockers to merging this and #565?

@JanProvaznik JanProvaznik merged commit 531f299 into dotnet:main Jan 9, 2025
5 checks passed
@JanProvaznik
Copy link
Member Author

@baronfel nope, I was just waiting if there would be any changes agreed to wrt what does main in this repo mean, but for now I merged and main at the moment is what will be deployed

@richlander
Copy link
Member

Why do the preview and stable scripts have such different paths and names? Ideally, they'd have similar paths and the same name.

Separately, when are we going to update the non-preview version?

@baronfel
Copy link
Member

The reason for the script paths is purely historical - it's something that only @leecow and @rbhanda have ever touched and isn't part of 'the install scripts' as a source artifact. I agree that unifying them would be useful conceptually, but there might be other reasons why they've been kept separate.

re: update cadence I think we'd been thinking of early next week? now that the redirects are being handled for the website we no longer have to do PRs there, we can simply ask @rbhanda to upload the new versions to the storage whenever we have sufficient test coverage. Usually this happens by preflighting the changes in arcade - maybe @mmitche can help with that?

@richlander
Copy link
Member

richlander commented Jan 11, 2025

Right. Arcade flow was going to be my next q.

There seems to be a lot of "purely historical". We need to change these things. As they say, never waste a crisis.

Also, looks like only the .sh scripts was promoted to preview. I don't see the .ps1 file there at all.

@leecow
Copy link
Member

leecow commented Jan 13, 2025

https://builds.dotnet.microsoft.com/dotnet/release/install-preview/install-dotnet-preview.sh

This was created based on customer request. The script provides a way for Linux users to install previews using the package manager, rather than tar.gz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "no cdn" concept from install script.
5 participants