Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0.1xx] Fix --use-current-runtime for linux-musl-arm64 #14637

Closed
wants to merge 5 commits into from

Conversation

am11
Copy link
Member

@am11 am11 commented Oct 1, 2022

cc @tmds

@tmds
Copy link
Member

tmds commented Oct 1, 2022

This is about ensuring NETCoreSdkPortableRuntimeIdentifier (in <DOTNET_ROOT>/sdk/<version>/Microsoft.NETCoreSdk.BundledVersions.props) is linux-musl-{arch} on musl based platforms.

The fix looks good for Microsoft's portable builds.

We also need to look at making it work for source-build .NET where Rid will be alpine.3.15-x64 for example, and this patch won't work.

cc @crummel @MichaelSimons @ayakael

@am11
Copy link
Member Author

am11 commented Oct 1, 2022

In some places, we are using conditions like:

https://github.com/dotnet/runtime/blob/c8f9f2949a243c411bd05278efab3f5a857cd0c1/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets#L7

    <OSIdentifier Condition="$(RuntimeIdentifier.StartsWith('linux-musl')) OR $(RuntimeIdentifier.StartsWith('alpine'))">linux-musl</OSIdentifier>

Though it's not ideal (for other musl-based distros), it will cover the officially supported platform matrix.

@am11 am11 closed this Oct 1, 2022
@am11 am11 reopened this Oct 1, 2022
@am11 am11 changed the title Fix --use-current-runtime for linux-musl-arm64 [release/7.0.1xx] Fix --use-current-runtime for linux-musl-arm64 Oct 1, 2022
@marcpopMSFT
Copy link
Member

@MichaelSimons is this for rtm?

@MichaelSimons
Copy link
Member

Closing in favor of #14647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants