Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/arcade #17126

Merged
merged 7 commits into from
Aug 10, 2023
Merged

[main] Update dependencies from dotnet/arcade #17126

merged 7 commits into from
Aug 10, 2023

Conversation

dotnet-maestro[bot]
Copy link

@dotnet-maestro dotnet-maestro bot commented Aug 4, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 7787dd03-cbf4-4297-391c-08d8e9750bf8
  • Build: 20230809.5
  • Date Produced: August 9, 2023 3:51:11 PM UTC
  • Commit: bebd2de1988036b47ecefc7e72b66ce2f403e43d
  • Branch: refs/heads/main

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23381.1 to 1.0.0-beta.23408.1 (parent: Microsoft.DotNet.Arcade.Sdk)

dotnet-maestro bot added 2 commits August 4, 2023 12:13
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
4715c15 
…803.7

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.CMake.Sdk
 From Version 8.0.0-beta.23402.2 -> To Version 8.0.0-beta.23403.7
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
de1f8ee 
…804.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.CMake.Sdk
 From Version 8.0.0-beta.23402.2 -> To Version 8.0.0-beta.23404.2
@v-wuzhai
Copy link
Member

v-wuzhai commented Aug 7, 2023

@dotnet/source-build-internal Could you take a look at the failures here?

/vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/SourceBuild/SourceBuildArcade.targets(89,5): error : No source-build artifacts were found and the resulting intermediate is empty. [/vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/SourceBuild/AfterSourceBuild.proj]

@MichaelSimons
Copy link
Member

@oleksandr-didyk - Looks like dotnet/arcade#13126 caught something. Can you take a look? TIA

@MichaelSimons
Copy link
Member

The property set in dotnet/arcade#13126 is likely not flowing in as expected. This might need to be set within the repo's sourcebuild.props file.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
3b47730 
…807.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.CMake.Sdk
 From Version 8.0.0-beta.23402.2 -> To Version 8.0.0-beta.23407.1
@oleksandr-didyk
Copy link

The property set in dotnet/arcade#13126 is likely not flowing in as expected. This might need to be set within the repo's sourcebuild.props file.

I'll take a look

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
9d4d656 
…808.6

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.CMake.Sdk
 From Version 8.0.0-beta.23402.2 -> To Version 8.0.0-beta.23408.6

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23381.1 -> To Version 1.0.0-beta.23407.1 (parent: Microsoft.DotNet.Arcade.Sdk
@oleksandr-didyk
Copy link

The property set in dotnet/arcade#13126 is likely not flowing in as expected. This might need to be set within the repo's sourcebuild.props file.

I'll take a look

Yes, you are correct, the prop is set in the wrong file.

@MichaelSimons what would be the best way to unblock this flow until the change in nuget for the SourceBuild.props flows in? A patch for Arcade or something simpler?

@MichaelSimons
Copy link
Member

@MichaelSimons what would be the best way to unblock this flow until the change in nuget for the SourceBuild.props flows in? A patch for Arcade or something simpler?

Yes, Create a NuGet PR and then create a patch from it and add it to this PR.

dotnet-maestro bot and others added 3 commits August 10, 2023 12:14
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
3be66ce 
…809.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.CMake.Sdk
 From Version 8.0.0-beta.23402.2 -> To Version 8.0.0-beta.23409.5

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23381.1 -> To Version 1.0.0-beta.23408.1 (parent: Microsoft.DotNet.Arcade.Sdk
@oleksandr-didyk
fixup incorrect prop placement
cc0f6a4
@oleksandr-didyk
add patch for empty intermediate in nuget
9573605
@oleksandr-didyk oleksandr-didyk requested a review from a team as a code owner August 10, 2023 12:29
@MichaelSimons MichaelSimons merged commit b68c096 into main Aug 10, 2023
@MichaelSimons MichaelSimons deleted the darc-main-f0d70019-4881-44ad-8430-af0399123997 branch August 10, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelSimons MichaelSimons MichaelSimons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-wuzhai @MichaelSimons @oleksandr-didyk