Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide extra properties for VMR build jobs #20021

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Provide extra properties for VMR build jobs #20021

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e64104a
Provide extra properties for VMR build jobs
mthalman Jul 16, 2024
fc36b94
Use pass-thru option
mthalman Jul 16, 2024
27e42fe
Also update tests
mthalman Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion eng/pipelines/templates/jobs/vmr-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ parameters:
type: boolean
default: false

# Freeform field for extra values to pass to build.sh for special build modes
- name: extraProperties
type: string
default: ''

jobs:
- job: ${{ parameters.buildName }}_${{ parameters.architecture }}
timeoutInMinutes: 150
Expand Down Expand Up @@ -230,7 +235,12 @@ jobs:
customBuildArgs="$customBuildArgs --use-mono-runtime"
fi

docker run --rm -v "$(sourcesPath):/vmr" -w /vmr $customRunArgs ${{ parameters.container }} ./build.sh --clean-while-building $(additionalBuildArgs) $customBuildArgs
extraProperties="${{ parameters.extraProperties }}"
if [[ -n "$extraProperties" ]]; then
extraProperties="-- $extraProperties"
fi

docker run --rm -v "$(sourcesPath):/vmr" -w /vmr $customRunArgs ${{ parameters.container }} ./build.sh --clean-while-building $(additionalBuildArgs) $customBuildArgs $extraProperties
displayName: Build

- script: |
Expand Down