Add event handling methods #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-device-bindings
… setup If an interrupt happens while the pin is still being configured, undefined behavior could occur.
Allows us to trigger on pins where we lost the interrupt, at least in most cases (obviously, very short pulses on multiple inputs will still lose some)
krwq
reviewed
Oct 19, 2023
| @@ -315,37 +326,55 @@ protected PinValue InternalReadInterrupt(Port port) | |||
| /// </returns> | |||
| public PinValue ReadInterrupt() => InternalReadInterrupt(Port.PortA); | |||
|
|
|||
| private byte SetBit(byte data, int bitNumber) => (byte)(data | (1 << bitNumber)); | |||
krwq
approved these changes
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2134
I had the
EnableInterruptOnChangewritten long ago already, but apparently forgot to write a PR for it. Now that's done, together with the support for event handling using the "normal" GpioDriver methods.Microsoft Reviewers: Open in CodeFlow