Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm64 build/test/publish. #5860

Merged
merged 45 commits into from
Jul 12, 2021
Merged

Arm64 build/test/publish. #5860

merged 45 commits into from
Jul 12, 2021

Conversation

michaelgsharp
Copy link
Member

@michaelgsharp michaelgsharp commented Jun 24, 2021

This PR adds in Arm64 to the building/testing/publishing.

It adds a way to check for the native binaries for the tests. This allows us to skip tests if the native binary doesn't exist, but run them if they do (like OnnxRuntime on Arm64. Doesn't have a pre-compiled binary, but if the user compiles it and drops it in, it will run).

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #5860 (591a183) into main (0fac0ba) will decrease coverage by 0.07%.
The diff coverage is 52.83%.

@@            Coverage Diff             @@
##             main    #5860      +/-   ##
==========================================
- Coverage   68.26%   68.19%   -0.08%     
==========================================
  Files        1134     1142       +8     
  Lines      241961   242367     +406     
  Branches    25302    25355      +53     
==========================================
+ Hits       165178   165282     +104     
- Misses      70145    70407     +262     
- Partials     6638     6678      +40     
Flag Coverage Δ
Debug 68.19% <52.83%> (-0.08%) ⬇️
production 62.87% <ø> (-0.06%) ⬇️
test 88.56% <52.83%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...est/Microsoft.ML.Predictor.Tests/TestPredictors.cs 70.11% <ø> (+0.49%) ⬆️
....TestFramework/Attributes/LightGBMFactAttribute.cs 83.33% <0.00%> (-16.67%) ⬇️
...estFramework/Attributes/LightGBMTheoryAttribute.cs 83.33% <0.00%> (-16.67%) ⬇️
...est/Microsoft.ML.TestFramework/BaseTestBaseline.cs 76.62% <0.00%> (+2.09%) ⬆️
test/Microsoft.ML.TestFramework/TestCommandBase.cs 39.41% <ø> (ø)
test/Microsoft.ML.Tests/DatabaseLoaderTests.cs 93.33% <ø> (ø)
...est/Microsoft.ML.Tests/FeatureContributionTests.cs 98.68% <ø> (ø)
.../Scenarios/Api/Estimators/SimpleTrainAndPredict.cs 94.73% <ø> (ø)
...rosoft.ML.Tests/TrainerEstimators/FAFMEstimator.cs 100.00% <ø> (ø)
...Microsoft.ML.Tests/TrainerEstimators/LbfgsTests.cs 97.45% <ø> (ø)
... and 55 more

@michaelgsharp michaelgsharp changed the title Arm helix changes. WIP Arm64 build/test/publish. Jun 28, 2021
@michaelgsharp michaelgsharp marked this pull request as ready for review June 28, 2021 21:27
@michaelgsharp michaelgsharp requested a review from a team June 28, 2021 21:27
build/vsts-ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @michaelgsharp. Nice work here!

I only had a handful of very minor comments.

@michaelgsharp michaelgsharp merged commit 34eb983 into dotnet:main Jul 12, 2021
@michaelgsharp michaelgsharp deleted the arm-helix branch July 15, 2021 19:16
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants