-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arm64 build/test/publish. #5860
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5860 +/- ##
==========================================
- Coverage 68.26% 68.19% -0.08%
==========================================
Files 1134 1142 +8
Lines 241961 242367 +406
Branches 25302 25355 +53
==========================================
+ Hits 165178 165282 +104
- Misses 70145 70407 +262
- Partials 6638 6678 +40
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tarekgh
reviewed
Jun 28, 2021
tarekgh
reviewed
Jun 28, 2021
tarekgh
reviewed
Jun 28, 2021
tarekgh
reviewed
Jun 28, 2021
tarekgh
reviewed
Jun 28, 2021
test/Microsoft.ML.TestFramework/Attributes/NotCentOS7FactAttribute.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jul 8, 2021
eerhardt
reviewed
Jul 9, 2021
test/Microsoft.ML.CodeGenerator.Tests/ApprovalTests/ConsoleCodeGeneratorTests.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jul 9, 2021
eerhardt
reviewed
Jul 9, 2021
test/Microsoft.ML.TestFramework/Attributes/BenchmarkTheoryAttribute.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jul 9, 2021
test/Microsoft.ML.TestFramework/DataPipe/PartitionedFileLoaderTests.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jul 9, 2021
eerhardt
reviewed
Jul 9, 2021
test/Microsoft.ML.TestFrameworkCommon/Attributes/NativeDependencyFact.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jul 9, 2021
eerhardt
reviewed
Jul 12, 2021
test/Microsoft.ML.CodeGenerator.Tests/ApprovalTests/ConsoleCodeGeneratorTests.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jul 12, 2021
test/Microsoft.ML.CodeGenerator.Tests/ApprovalTests/ConsoleCodeGeneratorTests.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Jul 12, 2021
eerhardt
approved these changes
Jul 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @michaelgsharp. Nice work here!
I only had a handful of very minor comments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in Arm64 to the building/testing/publishing.
It adds a way to check for the native binaries for the tests. This allows us to skip tests if the native binary doesn't exist, but run them if they do (like OnnxRuntime on Arm64. Doesn't have a pre-compiled binary, but if the user compiles it and drops it in, it will run).