-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NuGet README file #5900
Add NuGet README file #5900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, been OOF but I'm back now. Path needs fixing, but otherwise I think its good.
I'm thinking that maybe its getting stuck on the symbols package. I was able to get the readme in the normal package just fine, but it just fails when it tries to do the symbols one. |
@luisquintanilla What version of the .NET SDK are you using to pack? We had an issue that didn't allow README inclusion when using snupkg for symbols, but it was fixed in .NET 6 RC 2. |
@chgill-MSFT I believe ML.NET targets .NET Standard 2.0. @michaelgsharp would know better though. |
The PR that updated us to use the fixed version of .NET 6 just went in yesterday. I have fixed the include to point to the right readme file and this now works as expected. Once the builds pass I can merge this in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov Report
@@ Coverage Diff @@
## main #5900 +/- ##
==========================================
+ Coverage 68.19% 68.58% +0.39%
==========================================
Files 1142 1146 +4
Lines 242367 245395 +3028
Branches 25355 25634 +279
==========================================
+ Hits 165273 168314 +3041
+ Misses 70409 70385 -24
- Partials 6685 6696 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
We are excited to review your PR.
So we can do the best job, please check:
Fixes #nnnn
in your description to cause GitHub to automatically close the issue(s) when your PR is merged.Fixes #5899