Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NuGet README file #5900

Merged
merged 8 commits into from
Nov 19, 2021
Merged

Add NuGet README file #5900

merged 8 commits into from
Nov 19, 2021

Conversation

luisquintanilla
Copy link
Contributor

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

Fixes #5899

@luisquintanilla luisquintanilla marked this pull request as draft August 9, 2021 22:03
Copy link
Member

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, been OOF but I'm back now. Path needs fixing, but otherwise I think its good.

@michaelgsharp
Copy link
Member

I'm thinking that maybe its getting stuck on the symbols package. I was able to get the readme in the normal package just fine, but it just fails when it tries to do the symbols one.

@chrisraygill
Copy link

@luisquintanilla What version of the .NET SDK are you using to pack? We had an issue that didn't allow README inclusion when using snupkg for symbols, but it was fixed in .NET 6 RC 2.

@luisquintanilla
Copy link
Contributor Author

luisquintanilla commented Nov 11, 2021

@chgill-MSFT I believe ML.NET targets .NET Standard 2.0. @michaelgsharp would know better though.

@michaelgsharp
Copy link
Member

The PR that updated us to use the fixed version of .NET 6 just went in yesterday. I have fixed the include to point to the right readme file and this now works as expected. Once the builds pass I can merge this in.

@michaelgsharp michaelgsharp marked this pull request as ready for review November 19, 2021 00:00
Copy link
Member

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: LGTM.

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #5900 (39ae7dc) into main (526215d) will increase coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5900      +/-   ##
==========================================
+ Coverage   68.19%   68.58%   +0.39%     
==========================================
  Files        1142     1146       +4     
  Lines      242367   245395    +3028     
  Branches    25355    25634     +279     
==========================================
+ Hits       165273   168314    +3041     
+ Misses      70409    70385      -24     
- Partials     6685     6696      +11     
Flag Coverage Δ
Debug 68.58% <ø> (+0.39%) ⬆️
production 63.38% <ø> (+0.51%) ⬆️
test 88.67% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0.00%> (-20.52%) ⬇️
...c/Microsoft.ML.Data/Prediction/PredictionEngine.cs 87.83% <0.00%> (-4.81%) ⬇️
src/Microsoft.ML.TimeSeries/PredictionEngine.cs 76.96% <0.00%> (-3.63%) ⬇️
...ansforms/PermutationFeatureImportanceExtensions.cs 92.30% <0.00%> (-3.57%) ⬇️
src/Microsoft.ML.OnnxTransformer/OnnxUtils.cs 84.48% <0.00%> (-2.15%) ⬇️
.../Microsoft.ML.Data/Model/ModelOperationsCatalog.cs 53.60% <0.00%> (-1.78%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 25.38% <0.00%> (-1.53%) ⬇️
src/Microsoft.Data.Analysis/Strings.Designer.cs 43.26% <0.00%> (-0.95%) ⬇️
src/Microsoft.ML.Data/DataView/CacheDataView.cs 83.96% <0.00%> (-0.68%) ⬇️
src/Microsoft.ML.Transforms/GroupTransform.cs 91.37% <0.00%> (-0.64%) ⬇️
... and 75 more

@michaelgsharp michaelgsharp merged commit b45b31e into dotnet:main Nov 19, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create README for NuGet packages
3 participants