[msbuild] Remove unused parameters from the CompileEntitlement task. (#…

…18945)
dotnet · Sep 11, 2023 · 2fba9a8 · 2fba9a8
1 parent 8b3bf35
commit 2fba9a8
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 17 deletions.
diff --git a/msbuild/Xamarin.MacDev.Tasks/Tasks/CompileEntitlementsTaskBase.cs b/msbuild/Xamarin.MacDev.Tasks/Tasks/CompileEntitlementsTaskBase.cs
@@ -48,9 +48,6 @@ public abstract class CompileEntitlementsTaskBase : XamarinTask {
 		[Required]
 		public string AppBundleDir { get; set; } = string.Empty;
 
-		[Required]
-		public string AppIdentifier { get; set; } = string.Empty;
-
 		[Required]
 		public string BundleIdentifier { get; set; } = string.Empty;
 
@@ -63,14 +60,8 @@ public abstract class CompileEntitlementsTaskBase : XamarinTask {
 
 		public string Entitlements { get; set; } = string.Empty;
 
-		[Required]
-		public bool IsAppExtension { get; set; }
-
 		public string ProvisioningProfile { get; set; } = string.Empty;
 
-		[Required]
-		public string SdkDevPath { get; set; } = string.Empty;
-
 		public bool SdkIsSimulator { get; set; }
 
 		[Required]

diff --git a/msbuild/Xamarin.Shared/Xamarin.Shared.targets b/msbuild/Xamarin.Shared/Xamarin.Shared.targets
@@ -655,17 +655,14 @@ Copyright (C) 2018 Microsoft. All rights reserved.
 			SessionId="$(BuildSessionId)"
 			Condition="'$(IsMacEnabled)' == 'true'"
 			AppBundleDir="$(AppBundleDir)"
-			AppIdentifier="$(_AppIdentifier)"
 			BundleIdentifier="$(_BundleIdentifier)"
 			CustomEntitlements="@(CustomEntitlements)"
 			Entitlements="$(CodesignEntitlements)"
 			CompiledEntitlements="$(_CompiledEntitlementsPath)"
-			IsAppExtension="$(IsAppExtension)"
 			ProvisioningProfile="$(_ProvisioningProfile)"
 			SdkIsSimulator="$(_SdkIsSimulator)"
 			SdkPlatform="$(_SdkPlatform)"
 			SdkVersion="$(_SdkVersion)"
-			SdkDevPath="$(_SdkDevPath)"
 			TargetFrameworkMoniker="$(_ComputedTargetFrameworkMoniker)"
 			Debug="$(_BundlerDebug)"
 			>

diff --git a/msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.iOS.HotRestart.targets b/msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.iOS.HotRestart.targets
@@ -138,16 +138,13 @@
 
 		<CompileEntitlements
 			AppBundleDir="$(HotRestartAppBundlePath)"
-			AppIdentifier="$(_AppIdentifier)"
 			BundleIdentifier="$(_BundleIdentifier)"
 			Entitlements="$(_HotRestartEntitlementsFile)"
 			CompiledEntitlements="$(HotRestartAppBundlePath)\Entitlements.plist"
-			IsAppExtension="$(IsAppExtension)"
 			ProvisioningProfile="$(_ProvisioningProfileId)"
 			SdkIsSimulator="$(_SdkIsSimulator)"
 			SdkPlatform="iPhoneOS"
 			SdkVersion="12.2"
-			SdkDevPath=" "
 			TargetFrameworkMoniker="$(_ComputedTargetFrameworkMoniker)" />
 	</Target>
 

diff --git a/tests/msbuild/Xamarin.MacDev.Tasks.Tests/TaskTests/CompileEntitlementsTaskTests.cs b/tests/msbuild/Xamarin.MacDev.Tasks.Tests/TaskTests/CompileEntitlementsTaskTests.cs
@@ -28,11 +28,9 @@ CustomCompileEntitlements CreateEntitlementsTask (out string compiledEntitlement
 			var task = CreateTask<CustomCompileEntitlements> ();
 
 			task.AppBundleDir = AppBundlePath;
-			task.AppIdentifier = "32UV7A8CDE.com.xamarin.MySingleView";
 			task.BundleIdentifier = "com.xamarin.MySingleView";
 			task.CompiledEntitlements = new TaskItem (Path.Combine (MonoTouchProjectObjPath, "Entitlements.xcent"));
 			task.Entitlements = Path.Combine (Path.GetDirectoryName (GetType ().Assembly.Location), "Resources", "Entitlements.plist");
-			task.IsAppExtension = false;
 			task.ProvisioningProfile = Path.Combine (Path.GetDirectoryName (GetType ().Assembly.Location), "Resources", "profile.mobileprovision");
 			task.SdkPlatform = "iPhoneOS";
 			task.SdkVersion = "6.1";