Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[net10.0] [dotnet] Disable aggressive attribute trimming when using N…
…ativeAOT. Fixes #22065. (#22151) Aggressive attribute trimming removes attributes used by the trimmer. This is fine as long as we don't run _two_ trimmers - because then the first pass would remove attributes needed by the second pass, which is exactly what happens when we're building using NativeAOT: we first run ILLink, then NativeAOT's trimmer. If aggressive attribute trimming is enabled in this scenario, ILLink will remove attributes required by NativeAOT to work correctly, so disable aggressive attribute trimming. Fixes #22065.
- Loading branch information
1 parent
d246add
commit 9c19f63
9c19f63There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ [CI Build] Build passed (Build packages) ✅
Pipeline on Agent
Hash: 9c19f630b4ed94074f12a2e6e3ef83cf97f89a81 [CI build]
9c19f63There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ [CI Build] Build passed (Build macOS tests) ✅
Pipeline on Agent
Hash: 9c19f630b4ed94074f12a2e6e3ef83cf97f89a81 [CI build]
9c19f63There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ [CI Build] Build passed (Detect API changes) ✅
Pipeline on Agent
Hash: 9c19f630b4ed94074f12a2e6e3ef83cf97f89a81 [CI build]
9c19f63There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻
✅ All tests on macOS M1 - Mac Monterey (12) passed.
Pipeline on Agent
Hash: 9c19f630b4ed94074f12a2e6e3ef83cf97f89a81 [CI build]
9c19f63There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻
✅ All tests on macOS X64 - Mac Sonoma (14) passed.
Pipeline on Agent
Hash: 9c19f630b4ed94074f12a2e6e3ef83cf97f89a81 [CI build]
9c19f63There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻
✅ All tests on macOS arm64 - Mac Sequoia (15) passed.
Pipeline on Agent
Hash: 9c19f630b4ed94074f12a2e6e3ef83cf97f89a81 [CI build]
9c19f63There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻
✅ All tests on macOS M1 - Mac Ventura (13) passed.
Pipeline on Agent
Hash: 9c19f630b4ed94074f12a2e6e3ef83cf97f89a81 [CI build]
9c19f63There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ [CI Build] Windows Integration Tests failed ❌
❌ Failed ❌
Pipeline on Agent
Hash: 9c19f630b4ed94074f12a2e6e3ef83cf97f89a81 [CI build]
9c19f63There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ API diff for current PR / commit
.NET ( No breaking changes )
❗ API diff vs stable (Breaking changes)
.NET ( ❗ Breaking changes ❗ )
ℹ️ Generator diff
Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)
Pipeline on Agent
Hash: 9c19f630b4ed94074f12a2e6e3ef83cf97f89a81 [CI build]
9c19f63There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 [CI Build] Test results 🚀
Test results
✅ All tests passed on VSTS: test results.
🎉 All 112 tests passed 🎉
Tests counts
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download
Pipeline on Agent
Hash: 9c19f630b4ed94074f12a2e6e3ef83cf97f89a81 [CI build]