Skip to content

Commit

Permalink
[release/7.0.2xx-xcode14.3] [dotnet] Add a missing IsMacEnabled check…
Browse files Browse the repository at this point in the history
… before executing a task in the _ComputeLinkerArguments target. (#18221)

This fixes an issue where the build would fail on Windows if the Windows
machine wasn't connected to a remote Mac.

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1808448.


Backport of #18145

Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
  • Loading branch information
1 parent 4313bff commit edd0594
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion dotnet/targets/Xamarin.Shared.Sdk.targets
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,12 @@
</ItemGroup>

<!-- Create the file with our custom linker options -->
<WriteLinesToFile SessionId="$(BuildSessionId)" File="$(_CustomLinkerOptionsFile)" Lines="$(_CustomLinkerOptions)" Overwrite="true" />
<WriteLinesToFile
SessionId="$(BuildSessionId)"
Condition="'$(IsMacEnabled)' == 'true'"
File="$(_CustomLinkerOptionsFile)"
Lines="$(_CustomLinkerOptions)"
Overwrite="true" />
</Target>

<PropertyGroup>
Expand Down

6 comments on commit edd0594

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

@vs-mobiletools-engineering-service2

This comment was marked as outdated.

Please sign in to comment.