Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For iOS builds runtimeconfig.bin isn't bundled properly from Windows (neither for remote builds nor for Hot Restart builds) #17579

Closed
vsfeedback opened this issue Feb 21, 2023 · 0 comments · Fixed by #18103
Closed

For iOS builds runtimeconfig.bin isn't bundled properly from Windows (neither for remote builds nor for Hot Restart builds) #17579

vsfeedback opened this issue Feb 21, 2023 · 0 comments · Fixed by #18103
Assignees
@rolfbjarne
Labels
bug If an issue is a bug or a pull request a bug fix windows-only The issue only occur on Windows
Milestone
.NET 8

Comments

@vsfeedback
Copy link

This issue has been moved from a ticket on Developer Community.

[severity:I'm unable to use this version]
Repro: https://github.com/rolfbjarne/AppSwitchNullabilitySupportedTest

Build & run on Window using VS.

  1. Building & running remotely shows "Switch is not set" after clicking the button.
  2. Building & running locally using Hot Restart shows "Switch is set to: false" after clicking the button

The correct behavior only occurs when building on a Mac:

  1. Build & run using VSMac and the text shows "Switch is set to: true" after clicking the button.

Ref: #16228 (this is the underlying cause for that issue).

Original Comments

Feedback Bot on 1/24/2023, 03:55 AM:

(private comment, text removed)

Original Solutions

(no solutions)
@rolfbjarne rolfbjarne added this to the .NET 8 milestone Feb 21, 2023
@rolfbjarne rolfbjarne added bug If an issue is a bug or a pull request a bug fix windows-only The issue only occur on Windows labels Feb 21, 2023
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Feb 24, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
d1aa096 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Mar 6, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
ff318c0 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Mar 7, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
37599d8 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Mar 7, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
c42647f 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Mar 7, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
24696b6 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Mar 8, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
f3e0d54 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Mar 14, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
4d70866 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Mar 22, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
6b5d7dd 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Mar 22, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
b900c2c 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Mar 23, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
dc2d3c1 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Mar 28, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
ea1928c 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Apr 10, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
48487d0 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Apr 11, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
cc3e92d 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Apr 11, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
8bb9bf4 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Apr 12, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
dfdb9c5 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Apr 13, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
e8198cc 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Apr 17, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
6daafb9 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Apr 17, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
50fd73e 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Apr 18, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
d649383 
…ish. Contributes towards dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows (once we've fixed the Windows build to use
ResolvedFileToPublish as the source of truth, like we do on macOS).

This is the first part of a fix for dotnet#17579.
@rolfbjarne rolfbjarne mentioned this issue Apr 18, 2023
Merged
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Apr 18, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
c1ecdf8 
…ish. Contributes towards dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows (once we've fixed the Windows build to use
ResolvedFileToPublish as the source of truth, like we do on macOS).

This is the first part of a fix for dotnet#17579.
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Apr 18, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
d0209f9 
…ish. Fixes dotnet#17579.

This makes it unnecessary to special-case this file for it to copied correctly
when building on Windows.

Fixes dotnet#17579.
rolfbjarne added a commit that referenced this issue Apr 19, 2023
@rolfbjarne
[dotnet] Include the parsed runtimeconfig.bin into ResolvedFileToPubl…
9615de3 
…ish. Contributes towards #17579. (#18087)

This makes it unnecessary to special-case this file for it to copied
correctly when building on Windows (once we've fixed the Windows build to use
ResolvedFileToPublish as the source of truth, like we do on macOS).

This is the first part of a fix for
#17579.
@rolfbjarne rolfbjarne mentioned this issue Apr 25, 2023
Merged
@rolfbjarne rolfbjarne self-assigned this Apr 25, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rolfbjarne rolfbjarne

Labels
bug If an issue is a bug or a pull request a bug fix windows-only The issue only occur on Windows
Projects
None yet
Milestone
.NET 8
2 participants
@rolfbjarne @vsfeedback