Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hot Restart: show a warning or error if trying to link with a static library #17640

Closed
rolfbjarne opened this issue Feb 28, 2023 · 0 comments · Fixed by #18940
Closed

Hot Restart: show a warning or error if trying to link with a static library #17640

rolfbjarne opened this issue Feb 28, 2023 · 0 comments · Fixed by #18940
Labels
enhancement The issue or pull request is an enhancement
Milestone
.NET 8

Comments

@rolfbjarne
Copy link
Member

rolfbjarne commented Feb 28, 2023 •
edited
Loading

Linking with a static library won't work with hot restart (it's a known limitation: https://learn.microsoft.com/en-us/xamarin/xamarin-forms/deploy-test/hot-restart#limitations), so we should show let the developer know (either through a warning or an error) that things won't work as expected.

Ref: #17418
@rolfbjarne rolfbjarne added the enhancement The issue or pull request is an enhancement label Feb 28, 2023
@rolfbjarne rolfbjarne added this to the .NET 8 milestone Feb 28, 2023
rolfbjarne added a commit to rolfbjarne/xamarin-macios that referenced this issue Sep 6, 2023
@rolfbjarne
[msbuild] Warn when we detect that the app developer is trying to lin…
a8e97c7 
…k with a static library when using Hot Restart. Fixes dotnet#17640.

Warn when we detect that the app developer is trying to link with a static
library when using Hot Restart, because we don't support linking with static
libraries in that case.

Also change the resource generation for Xamarin.iOS.Tasks.Windows project to
generate the code-behind for the resources during the build (as opposed to by
the IDE - which won't happen unless using an IDE, while the build will always
happen).

Fixes dotnet#17640.
@rolfbjarne rolfbjarne mentioned this issue Sep 6, 2023
Merged
rolfbjarne added a commit that referenced this issue Sep 7, 2023
@rolfbjarne
[msbuild] Warn when we detect that the app developer is trying to lin…
08ad43a 
…k with a static library when using Hot Restart. Fixes #17640. (#18940)

Warn when we detect that the app developer is trying to link with a static
library when using Hot Restart, because we don't support linking with static
libraries in that case.

Also change the resource generation for Xamarin.iOS.Tasks.Windows project to
generate the code-behind for the resources during the build (as opposed to by
the IDE - which won't happen unless using an IDE, while the build will always
happen).

Fixes #17640.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue or pull request is an enhancement
Projects
None yet
Milestone
.NET 8
1 participant
@rolfbjarne