-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0.2xx] [dotnet] Add a missing IsMacEnabled check before executing a task in the _ComputeLinkerArguments target. #18149
Conversation
…the _ComputeLinkerArguments target. This fixes an issue where the build would fail on Windows if the Windows machine wasn't connected to a remote Mac. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1808448.
✅ API diff for current PR / commitNET (empty diffs)
✅ API diff vs stable.NET (No breaking changes)
✅ Generator diffGenerator diff is empty Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Ventura (13.0) failed ❌Failed tests are:
Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 4 tests failed, 73 tests passed. Failures❌ monotouch tests
Html Report (VSDrops) Download Successes
Pipeline on Agent |
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2197, https://github.com/xamarin/maccore/issues/2668). |
This fixes an issue where the build would fail on Windows if the Windows
machine wasn't connected to a remote Mac.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1808448.
Backport of #18145