Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RGen] Add docs to the SmartEnum generated methods. #22268

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

mandel-macaque
Copy link
Member

Add the documentation to the smart enum extension class and its methods.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@mandel-macaque mandel-macaque force-pushed the dev/mandel/generate-docs-rgen branch from 0f59135 to c51ad86 Compare March 3, 2025 22:06
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Add the documentation to the smart enum extension class and its methods.
@mandel-macaque mandel-macaque force-pushed the dev/mandel/generate-docs-rgen branch from c51ad86 to 119d318 Compare March 3, 2025 22:46
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build #119d318] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 2 tests failed, 110 tests passed.

Failures

❌ cecil tests

1 tests failed, 0 tests passed.
  • Cecil-based tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ dotnettests tests (MacCatalyst)

1 tests failed, 0 tests passed.
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 119d318f2e5af6bc6a31dbb3bfe76904c0da643f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #7e366e3] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 7e366e36e01baeffac57e38fc62657d5126d994b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #7e366e3] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 7e366e36e01baeffac57e38fc62657d5126d994b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #7e366e3] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 7e366e36e01baeffac57e38fc62657d5126d994b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #7e366e3] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 7e366e36e01baeffac57e38fc62657d5126d994b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #7e366e3] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 7e366e36e01baeffac57e38fc62657d5126d994b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #7e366e3] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 7e366e36e01baeffac57e38fc62657d5126d994b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #7e366e3] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 7e366e36e01baeffac57e38fc62657d5126d994b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 7e366e36e01baeffac57e38fc62657d5126d994b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #7e366e3] Windows Integration Tests passed 💻

All Windows Integration Tests passed.

Pipeline on Agent
Hash: 7e366e36e01baeffac57e38fc62657d5126d994b [PR build]

@mandel-macaque
Copy link
Member Author

Tests did pass in the last build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=11125105&view=results

Looks like we might have had either an outage or there is a bug in the commet code of the CI.

@mandel-macaque mandel-macaque merged commit 250d303 into main Mar 5, 2025
44 of 47 checks passed
@mandel-macaque mandel-macaque deleted the dev/mandel/generate-docs-rgen branch March 5, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants