Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RGen] Add default constructors doc strings. #22269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mandel-macaque
Copy link
Member

Add the doc strings in the generated default constructors.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@mandel-macaque mandel-macaque force-pushed the dev/mandel/generate-docs-rgen branch 2 times, most recently from c51ad86 to 119d318 Compare March 3, 2025 22:46
@mandel-macaque mandel-macaque force-pushed the dev/mandel/default-init-docs branch from ed6f4ed to 42f7537 Compare March 4, 2025 20:56
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Base automatically changed from dev/mandel/generate-docs-rgen to main March 5, 2025 13:54
Add the doc strings in the generated default constructors.
@mandel-macaque mandel-macaque force-pushed the dev/mandel/default-init-docs branch from 42f7537 to 47bf608 Compare March 5, 2025 14:26
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #47bf608] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 47bf6082cf7309b71afa9e290d905c5ba2bd834e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #47bf608] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 47bf6082cf7309b71afa9e290d905c5ba2bd834e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #47bf608] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 47bf6082cf7309b71afa9e290d905c5ba2bd834e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #47bf608] Windows Integration Tests passed 💻

All Windows Integration Tests passed.

Pipeline on Agent
Hash: 47bf6082cf7309b71afa9e290d905c5ba2bd834e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #47bf608] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 47bf6082cf7309b71afa9e290d905c5ba2bd834e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #47bf608] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 47bf6082cf7309b71afa9e290d905c5ba2bd834e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #47bf608] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 47bf6082cf7309b71afa9e290d905c5ba2bd834e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #47bf608] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 47bf6082cf7309b71afa9e290d905c5ba2bd834e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 47bf6082cf7309b71afa9e290d905c5ba2bd834e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build #47bf608] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 111 tests passed.

Failures

❌ generator tests

1 tests failed, 4 tests passed.
  • Roslyn Generator tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 47bf6082cf7309b71afa9e290d905c5ba2bd834e [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants