-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[devops] Install .NET before trying to install simulators. #22272
Conversation
Because installing simulators means running a C# project, which requires .NET to build. Also improve the .NET version check systemdependencies.sh to not blindly try to execute `dotnet`, but check for its presence first. This fixes a couple of issues on bots that don't have .NET installed.
✅ [PR Build #00a9909] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #00a9909] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [PR Build #00a9909] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [PR Build #00a9909] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [PR Build #00a9909] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [PR Build #00a9909] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [PR Build #00a9909] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )❗ API diff vs stable (Breaking changes).NET ( ❗ Breaking changes ❗ )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [CI Build #00a9909] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
🚀 [CI Build #00a9909] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 112 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Because installing simulators means running a C# project, which requires .NET to build.
Also improve the .NET version check systemdependencies.sh to not blindly try
to execute
dotnet
, but check for its presence first.This fixes a couple of issues on bots that don't have .NET installed.