Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono-api-html] Improve attribute handling. #22273

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rolfbjarne
Copy link
Member

  • Simplify and expand how custom attributes are written into the xml description
    by not doing any fancy computation about the attribute properties, instead just
    write out what's in IL: any constructor arguments + parameter arguments.
  • Compare and show attributes for types and members.
  • Special-case [Experimental] attributes:
    • Adding an [Experimental] attribute to an existing type/member is a breaking change.
    • If a type or a member has an [Experimental] attribute, no changes within are breaking.
  • Removal of an obsolete type/member is a breaking change, so show it as such.

rolfbjarne and others added 2 commits March 3, 2025 11:25
* Simplify and expand how custom attributes are written into the xml description
  by not doing any fancy computation about the attribute properties, instead just
  write out what's in IL: any constructor arguments + parameter arguments.
* Compare and show attributes for types and members.
* Special-case [Experimental] attributes:
  * Adding an [Experimental] attribute to an existing type/member  is a breaking change.
  * If a type or a member has an [Experimental] attribute, no changes within are breaking.
* Removal of an obsolete type/member is a breaking change, so show it as such.
Copy link
Contributor

github-actions bot commented Mar 3, 2025

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #63d5e01] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 63d5e0169a351ce1de08ce65aed3cd5bb889f698 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #63d5e01] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 63d5e0169a351ce1de08ce65aed3cd5bb889f698 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #63d5e01] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 63d5e0169a351ce1de08ce65aed3cd5bb889f698 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #63d5e01] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 63d5e0169a351ce1de08ce65aed3cd5bb889f698 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #63d5e01] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 63d5e0169a351ce1de08ce65aed3cd5bb889f698 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #63d5e01] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 63d5e0169a351ce1de08ce65aed3cd5bb889f698 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build #63d5e01] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 63d5e0169a351ce1de08ce65aed3cd5bb889f698 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #63d5e01] Windows Integration Tests passed 💻

All Windows Integration Tests passed.

Pipeline on Agent
Hash: 63d5e0169a351ce1de08ce65aed3cd5bb889f698 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 63d5e0169a351ce1de08ce65aed3cd5bb889f698 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne marked this pull request as ready for review March 4, 2025 21:32
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #63d5e01] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 112 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 63d5e0169a351ce1de08ce65aed3cd5bb889f698 [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants