-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mono-api-html] Improve attribute handling. #22273
base: main
Are you sure you want to change the base?
Conversation
* Simplify and expand how custom attributes are written into the xml description by not doing any fancy computation about the attribute properties, instead just write out what's in IL: any constructor arguments + parameter arguments. * Compare and show attributes for types and members. * Special-case [Experimental] attributes: * Adding an [Experimental] attribute to an existing type/member is a breaking change. * If a type or a member has an [Experimental] attribute, no changes within are breaking. * Removal of an obsolete type/member is a breaking change, so show it as such.
|
✅ [PR Build #63d5e01] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #63d5e01] Build passed (Build macOS tests) ✅Pipeline on Agent |
✅ [PR Build #63d5e01] Build passed (Detect API changes) ✅Pipeline on Agent |
💻 [PR Build #63d5e01] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [PR Build #63d5e01] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [PR Build #63d5e01] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [PR Build #63d5e01] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #63d5e01] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
✅ API diff for current PR / commit.NET ( No breaking changes )❗ API diff vs stable (Breaking changes).NET ( ❗ Breaking changes ❗ )ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #63d5e01] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 112 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
by not doing any fancy computation about the attribute properties, instead just
write out what's in IL: any constructor arguments + parameter arguments.