[iosurface] IOSurface is not usable before iOS/tvOS 11. Fixes #59201 #2706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apple rejects apps that links with the previously private IOSurface.framework. We were not sure about this [1] and had it disabled (this is removed). However another bug stopped our adjustment logic [2] from being executed. This is needed since `clang` picks up the private framework if it does not find the public one (even when asking for a weak framework), [1] https://bugzilla.xamarin.com/show_bug.cgi?id=59201 [2] Added a while ago for JavascriptCore
dalexsoto
reviewed
Sep 15, 2017
| @@ -336,7 +336,7 @@ public class NativeLinkTask : BuildTask | |||
| // /System/Library/PrivateFrameworks/JavaScriptCore.framework/JavaScriptCore instead of | |||
| // /System/Library/Frameworks/JavaScriptCore.framework/JavaScriptCore | |||
| // more details in https://bugzilla.xamarin.com/show_bug.cgi?id=31036 | |||
| if (Target.WeakFrameworks.Count > 0) | |||
| if (CompilerFlags.WeakFrameworks.Count > 0) | |||
dalexsoto
approved these changes
Sep 15, 2017
|
Build failure |
|
mmp-test failed with |
|
This seems unrelated since the only change is made to mtouch, not mmp. |
|
@spouliot I believe it is https://bugzilla.xamarin.com/show_bug.cgi?id=59277 I was going to look at a fix after I get #2685 working, should be trivial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple rejects apps that links with the previously private IOSurface.framework.
We were not sure about this [1] and had it disabled (this is removed).
However another bug stopped our adjustment logic [2] from being executed. This
is needed since
clangpicks up the private framework if it does not find thepublic one (even when asking for a weak framework),
[1] https://bugzilla.xamarin.com/show_bug.cgi?id=59201
[2] Added a while ago for JavascriptCore