Skip to content

Commit

Permalink
Remove DevopsNuget.config (#13814)
Browse files Browse the repository at this point in the history
* Remove DevopsNuget.config

* - keep nuget reference

* - no more cake for you xamarin

* - remove

* - remove adb

* - config

* - test

* - try mme

* - nuget

* - remove config
  • Loading branch information
PureWeen authored Feb 22, 2021
1 parent d84de5e commit 61ce3a6
Show file tree
Hide file tree
Showing 10 changed files with 4 additions and 29 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ WriteDevopsVariables.csproj
!**/Xamarin.Forms.Platform.GTK/Libs/**/*
!**/Xamarin.Forms.Build.Tasks/ErrorMessages.Designer.cs
!**/Xamarin.Forms.Maps.WPF/Properties/Settings.Designer.cs
!**/DevopsNuget.config
!**/Xamarin.Forms.Maps.GTK/Libs/**/*
/tools
*.svclog
Expand Down
File renamed without changes.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

```
dotnet tool install Cake.Tool -g
dotnet cake --target=provision
```

### Running
Expand Down
20 changes: 0 additions & 20 deletions build.cake
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ PowerShell:
//////////////////////////////////////////////////////////////////////
// ADDINS
//////////////////////////////////////////////////////////////////////
#addin "nuget:?package=Cake.Xamarin&version=3.0.2"
#addin "nuget:?package=Cake.Android.Adb&version=3.2.0"
#addin "nuget:?package=Cake.Git&version=0.21.0"
#addin "nuget:?package=Cake.Android.SdkManager&version=3.0.2"
#addin "nuget:?package=Cake.Boots&version=1.0.3.556"
#addin "nuget:?package=Cake.AppleSimulator&version=0.2.0"
Expand Down Expand Up @@ -1103,18 +1100,6 @@ Task ("cg-ios-deploy")
LaunchiOSApplication(sim.UDID, IOS_BUNDLE_ID);
});

Task("DeployAndroid")
.Description("Builds and deploy Android Control Gallery")
.Does(() =>
{
MSBuild(BUILD_TASKS_PROJ, GetMSBuildSettings().WithRestore());
MSBuild(ANDROID_CONTROLGALLERY_PROJ, GetMSBuildSettings().WithRestore());
BuildAndroidApk(ANDROID_CONTROLGALLERY_PROJ, sign:true, configuration:configuration);
AdbUninstall(ANDROID_BUNDLE_ID);
AdbInstall($"src/Controlgallery/src/Xamarin.Forms.ControlGallery.Android/bin/Debug/{ANDROID_BUNDLE_ID}-Signed.apk");
AmStartActivity($"{ANDROID_BUNDLE_ID}/md546303760447087909496d02dc7b17ae8.Activity1");
});

//////////////////////////////////////////////////////////////////////
// TASK TARGETS
//////////////////////////////////////////////////////////////////////
Expand Down Expand Up @@ -1194,11 +1179,6 @@ MSBuildSettings GetMSBuildSettings(PlatformTarget? platformTarget = PlatformTarg
buildSettings = buildSettings.WithProperty("XamarinFormsVersion", XamarinFormsVersion);
}

if(isCIBuild)
{
buildSettings = buildSettings.WithProperty("RestoreConfigFile", $"eng/DevopsNuget.config");
}

buildSettings.ArgumentCustomization = args => args.Append($"/nowarn:VSX1000 {MSBuildArguments}");
return buildSettings;
}
Expand Down
2 changes: 1 addition & 1 deletion build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Param(
)

# Restore Cake tool
& dotnet tool restore --configfile eng/DevopsNuget.config
& dotnet tool restore

# Build Cake arguments
$cakeArguments = @("$Script");
Expand Down
2 changes: 1 addition & 1 deletion build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ for i in "$@"; do
done

# Restore Cake tool
dotnet tool restore --configfile eng/DevopsNuget.config
dotnet tool restore

if [ $? -ne 0 ]; then
echo "An error occured while installing Cake."
Expand Down
1 change: 0 additions & 1 deletion eng/pipelines/common/build-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ steps:
inputs:
restoreSolution: ${{ parameters.slnPath }}
feedsToUse: config
nugetConfigPath: 'eng/DevopsNuget.config'

- script: build.cmd -Target BuildForNuget -ScriptArgs '--BUILD_CONFIGURATION="$(BuildConfiguration)"','--Build_ArtifactStagingDirectory="$(Build.ArtifactStagingDirectory)"'
name: winbuild
Expand Down
4 changes: 2 additions & 2 deletions eng/pipelines/handlers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ stages:
errorActionPreference: stop
- powershell: |
& dotnet restore Maui.sln --configfile eng\DevopsNuget.config
& dotnet restore Maui.sln
& dotnet build Maui.sln -c Debug -bl:$(LogDirectory)\Debug.binlog
& dotnet build Maui.sln -c Release -bl:$(LogDirectory)\Release.binlog
displayName: build samples
Expand Down Expand Up @@ -219,7 +219,7 @@ stages:
displayName: configure vsmac xcode
- bash: |
dotnet restore Maui.sln --configfile eng/DevopsNuget.config &&
dotnet restore Maui.sln &&
dotnet build Maui.sln -c Debug -bl:$(LogDirectory)/Debug.binlog &&
dotnet build Maui.sln -c Release -bl:$(LogDirectory)/Release.binlog
displayName: build samples
Expand Down
1 change: 0 additions & 1 deletion eng/pipelines/steps/build-android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ jobs:
command: restore
restoreSolution: 'Xamarin.Forms.sln'
feedsToUse: config
nugetConfigPath: 'DevopsNuget.config'

- task: Bash@3
displayName: 'Build Android $(renderers)'
Expand Down
1 change: 0 additions & 1 deletion eng/pipelines/steps/build-osx.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ steps:
command: restore
restoreSolution: 'Xamarin.Forms.sln'
feedsToUse: config
nugetConfigPath: 'DevopsNuget.config'

- task: InstallAppleCertificate@2
displayName: 'Install an Apple certificate'
Expand Down

0 comments on commit 61ce3a6

Please sign in to comment.