Possible Memory leaks? #12048
Comments
|
We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process. |
|
I suppose that this is the same problem I raised as an issue in #10578 and #12039. I think that actual pages do get disposed as I tried to use weak reference for the pushed page in one of the sample and the reference is eventually broken, which probably means that the page was disposed. I'm also unable to see instances of page or view model in VS memory profiler. What I see is a lot of UI bits left behind - controls, bindings, handlers... to me it appears that those are never properly disposed. The problem also seems to be getting progressively worse with more controls on pushed page. Unfortunately so far the MAUI team doesn't seem to care about this issue, even thought it probably affects all apps in serious manner. |
|
Sorry you feel that we don't care because we definitely do. It seems you are very experienced and knowledgeable in this area. We're more than happy to also take in any and all contributions you might have in this area to expedite things. Thank you for your detailed reports which is very helpful! |
|
Hi @jfversluis, I agree with @Vroomer that a lot of UI bits are left behind. The question from my side would be when can we see a memory profiler on mac to better profile our apps and narrow down the problems? PerfView is not on Mac and what described at https://github.com/xamarin/xamarin-macios/wiki/Profiling is good for speed analysis but not for memory analysis. Xcode Profiler does not help me with that, because it does not seem to work with maui projects (on my machine). |
Fixes: dotnet#12048 Context: https://github.com/jonathanpeppers/MemoryLeaksOniOS Context: https://stackoverflow.com/a/13059140 Issue dotnet#12048 has four scenarios that are currently fixed in `main` for Android and Windows. Unfortunately, one of the four scenarios fails on iOS due to its usage of `Button`. I could reproduce the issue by simply adding a `Button` to existing memory leak tests. `ButtonHandler.iOS.cs` has a "cycle": * `ButtonHandler` subscribes to events like `UIButton.TouchUpInside` making `UIButton` hold a strong reference to `ButtonHandler`. * `ButtonHandler` (like all handlers) has a strong reference to the `Microsoft.Maui.Button`. * `ButtonHandler` has a strong reference to `UIButton`. * `Microsoft.Maui.Button` has a strong reference to `ButtonHandler`. To solve this issue, we can make a nested classed named `ButtonProxy`: * Its purpose is subscribe to `UIButton.TouchUpInside` and invoke `Microsoft.Maui.Button.Clicked()`. * `ButtonProxy` has a weak reference to the `Microsoft.Maui.Button`. Now the `UIButton`, `ButtonProxy`, `ButtonHandler`, and `Microsoft.Maui.Button` can all be collected.
Fixes: dotnet#12048 Context: https://github.com/jonathanpeppers/MemoryLeaksOniOS Context: https://stackoverflow.com/a/13059140 Issue dotnet#12048 has four scenarios that are currently fixed in `main` for Android and Windows. Unfortunately, one of the four scenarios fails on iOS due to its usage of `Button`. I could reproduce the issue by simply adding a `Button` to existing memory leak tests. `ButtonHandler.iOS.cs` has a "cycle": * `ButtonHandler` subscribes to events like `UIButton.TouchUpInside` making `UIButton` hold a strong reference to `ButtonHandler`. * `ButtonHandler` (like all handlers) has a strong reference to the `Microsoft.Maui.Button`. * `ButtonHandler` has a strong reference to `UIButton`. * `Microsoft.Maui.Button` has a strong reference to `ButtonHandler`. To solve this issue, we can make a nested classed named `ButtonProxy`: * Its purpose is subscribe to `UIButton.TouchUpInside` and invoke `Microsoft.Maui.Button.Clicked()`. * `ButtonProxy` has a weak reference to the `Microsoft.Maui.Button`. Now the `UIButton`, `ButtonProxy`, `ButtonHandler`, and `Microsoft.Maui.Button` can all be collected.
Fixes: dotnet#12048 Context: https://github.com/jonathanpeppers/MemoryLeaksOniOS Context: https://stackoverflow.com/a/13059140 Issue dotnet#12048 has four scenarios that are currently fixed in `main` for Android and Windows. Unfortunately, one of the four scenarios fails on iOS due to its usage of `Button`. I could reproduce the issue by simply adding a `Button` to existing memory leak tests. `ButtonHandler.iOS.cs` has a "cycle": * `ButtonHandler` subscribes to events like `UIButton.TouchUpInside` making `UIButton` hold a strong reference to `ButtonHandler`. * `ButtonHandler` (like all handlers) has a strong reference to the `Microsoft.Maui.Button`. * `ButtonHandler` has a strong reference to `UIButton`. * `Microsoft.Maui.Button` has a strong reference to `ButtonHandler`. To solve this issue, we can make a nested classed named `ButtonProxy`: * Its purpose is subscribe to `UIButton.TouchUpInside` and invoke `Microsoft.Maui.Button.Clicked()`. * `ButtonProxy` has a weak reference to the `Microsoft.Maui.Button`. Now the `UIButton`, `ButtonProxy`, `ButtonHandler`, and `Microsoft.Maui.Button` can all be collected.
Fixes: #12048 Context: https://github.com/jonathanpeppers/MemoryLeaksOniOS Context: https://stackoverflow.com/a/13059140 Issue #12048 has four scenarios that are currently fixed in `main` for Android and Windows. Unfortunately, one of the four scenarios fails on iOS due to its usage of `Button`. I could reproduce the issue by simply adding a `Button` to existing memory leak tests. `ButtonHandler.iOS.cs` has a "cycle": * `ButtonHandler` subscribes to events like `UIButton.TouchUpInside` making `UIButton` hold a strong reference to `ButtonHandler`. * `ButtonHandler` (like all handlers) has a strong reference to the `Microsoft.Maui.Button`. * `ButtonHandler` has a strong reference to `UIButton`. * `Microsoft.Maui.Button` has a strong reference to `ButtonHandler`. To solve this issue, we can make a nested classed named `ButtonProxy`: * Its purpose is subscribe to `UIButton.TouchUpInside` and invoke `Microsoft.Maui.Button.Clicked()`. * `ButtonProxy` has a weak reference to the `Microsoft.Maui.Button`. Now the `UIButton`, `ButtonProxy`, `ButtonHandler`, and `Microsoft.Maui.Button` can all be collected.
ghost
locked as resolved and limited conversation to collaborators
samhouts
added
the
fixed-in-8.0.0-preview.4.8333
Eilon
added
the
t/perf
samhouts
added
the
memory-leak 💦
Description
We are seeing crashes of our app on iOS because of what looks to us like a memory shortage. So we took some time to break down the things we are seeing.
The provided Repro is doing the following.
After starting the app we call GC.Collect(); and GC.WaitForPendingFinalizers(); every 2 Seconds;
When navigating away from the inital page, we stop calling GC.Collect and WaitForPendingFinalizers.
When navigating back to the start page we start calling GC.Collect(); and GC.WaitForPendingFinalizers(); every 2 Seconds; again.
So in theory because the page is not in the backstack any more, and because it is not single instance on the ioc side, it should get collected.
Of my knowledge it is not guaranteed to Finalize. when calling Collect() and WaitForPendingFinalizers();
This is all fine, but after some time it should kick in. Right?
That is why we added a Page that get´s Finalized after same time.
After making the changes described in the different views we can see the views get finalized also.
So we would say these are Memoryleaks that can be worked around?
The biggest things we are seeing is that on iOS non of our pages get finalized. Even in the provided Repro an empty Contentpage is not finalizing. This could be because this is expected from your side.. But not for me.
If it is expected. Please give some context why.
If this is not expected, what can we do? Is there a workaround?
Steps to Reproduce
Link to public reproduction project repository
https://github.com/Larhei/Maui-Issues/tree/main/GarbageCollection
Version with bug
7.0 (current)
Last version that worked well
Unknown/Other
Affected platforms
iOS, Android, Windows
Affected platform versions
iOS, Android, Windows
Did you find any workaround?
For some things yes. Read the xaml ;-)
Relevant log output
No response
The text was updated successfully, but these errors were encountered: