[Windows] Fix crash in WebView updating the Source two times in a row #10456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
ghost
added
the
legacy-area-controls
mattleibow
requested changes
Oct 5, 2022
rmarinho
requested changes
Oct 12, 2022
| }; | ||
|
|
||
| // Kick off the initial navigation | ||
| _internalWebView.NavigateToString(html); | ||
| _internalWebView.CoreWebView2Initialized += (sender, args) => |
There was a problem hiding this comment.
Don't we need to unsubscribe this ?
|
To help focus and move faster, we're going to have fewer open PRs and focus on the ones we'll be working on in each release. This PR require more work or event think in a better approach and for that reason is not included in the next release so I close it for now. I will reopen it and adapt to changes later. |
Eilon
removed
the
legacy-area-controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix crash in Windows WebView updating the Source two times in a row.
Issues Fixed
Fixes #10438