Revert "[Windows] Fix default corner radius on Button" #10664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet#7128" This reverts commit ed53643.
ghost
added
the
|
Hey there @tj-devel709! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
approved these changes
Oct 13, 2022
mattleibow
reviewed
Oct 13, 2022
|
|
||
| if (radius >= 0) | ||
| platformButton.Resources.SetValueForAllKey(CornerRadiusResourceKeys, WinUIHelpers.CreateCornerRadius(radius)); | ||
| platformButton.Resources.SetValueForAllKey(CornerRadiusResourceKeys, WinUIHelpers.CreateCornerRadius(buttonStroke.CornerRadius)); |
There was a problem hiding this comment.
Should we use the radius field instead of getting the value again?
|
Fixes #10644 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
I added a small test to make sure the radius of the WinUI does not get set back to zero. |
mattleibow
reviewed
Oct 14, 2022
src/Core/tests/DeviceTests/Handlers/Window/WindowHandlerTests.Windows.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
The value of -1 means default rounding. So whatever the OS decides. |
mattleibow
approved these changes
Oct 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9515
#9515 Allows all the platforms to have the same default button border radius, but we want to keep the Windows default rounded corner style on buttons. Thanks @mattleibow and @PureWeen for spotting this!
Also peer programmed with @rachelkang!
Before the revert (no rounded corners):
After the revert (rounded corners):
Fixes #10644