Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Add support for Visual Studio on win-arm64 #11803

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

jonathanpeppers
Copy link
Member

Description of Change

Context: #11090
Context: https://github.com/xamarin/yaml-templates/pull/204
Context: dotnet/android#7471
Context: xamarin/xamarin-macios#16935

Updates the VSMAN files generated for our .NET workload to support Visual Studio on windows-arm64.

Context: dotnet#11090
Context: xamarin/yaml-templates#204
Context: dotnet/android#7471
Context: xamarin/xamarin-macios#16935

Updates the VSMAN files generated for our .NET workload to support
Visual Studio on windows-arm64.
@jonathanpeppers jonathanpeppers added platform/windows 🪟 area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions labels Dec 1, 2022
@mattleibow
Copy link
Member

Is there some flag or light that I can see on CI artifacts to make sure this all kicked in?

@jonathanpeppers
Copy link
Member Author

jonathanpeppers commented Dec 1, 2022

If you look at a signed build, like xamarin-android/main:

https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7029241&view=artifacts&pathAsName=false&type=publishedArtifacts

Microsoft.NET.Sdk.Android.Workload.net8.0.multitarget.vsman has:

  "packages": [
    {
      "id": "Microsoft.Android.Sdk.net8.34.0.0-preview.1.74",
      "version": "34.0.0.0",
      "type": "Msi",
      "machineArch": "arm64",

I don't know if you can see that until this is merged? Do PRs build .vsman files?

@mattleibow
Copy link
Member

Do PRs build .vsman files?

I don't think so, but I will check it once merged to confirm.

@jonathanpeppers jonathanpeppers merged commit 05ad340 into dotnet:main Dec 1, 2022
@jonathanpeppers jonathanpeppers deleted the nuget-msi-arm64 branch December 1, 2022 19:01
@jonathanpeppers
Copy link
Member Author

@mattleibow the build is done from where this merged, what artifact contains the .vsman file?

@pjcollins you might know.

@pjcollins
Copy link
Member

@jonathanpeppers
Copy link
Member Author

@Redth @mattleibow this looks right to me:

  "packages": [
    {
      "id": "Maui.Sdk.net7.7.0.0-ci.net7.7216",
      "version": "7.0.0.0",
      "type": "Msi",
      "machineArch": "arm64",

How do we backport to .NET 6 and 7?

@Redth
Copy link
Member

Redth commented Dec 5, 2022

/backport to net6.0

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Started backporting to net6.0: https://github.com/dotnet/maui/actions/runs/3622584727

@Redth
Copy link
Member

Redth commented Dec 5, 2022

/backport to net7.0

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/3622586873

@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! platform/windows 🪟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants