Show keyboard on Android entry/editor/searchbar focus #12890

rachelkang · 2023-01-24T19:22:01Z

Description of Change

Show keyboard on Android entry/editor/searchbar focus

Issues Fixed

Fixes #5983

src/Core/src/Handlers/Editor/EditorHandler.Android.cs

src/Core/src/Handlers/SearchBar/SearchBarHandler.Android.cs

src/Controls/tests/DeviceTests/Elements/Editor/EditorTests.Android.cs

github-actions · 2023-02-15T18:57:16Z

⚠️ Your code has been reformatted. ⚠️

src/Core/src/Platform/Android/KeyboardManager.cs

PureWeen

One case this doesn't cover is if a control is already focused and the keyboard is closed.

The problem here is that our Focus call inside controls feels like it's trying to be too smart.

It checks its own internal concept of IsFocused and then doesn't trigger the Handler logic.

My initial thought here is that we should move all of this focus code into the mappers.

I feel like we should move all of this focus code into a VisualElement CommandMapper so that users can even modify or adjust the focus code in general.

As is we sort of block the user from being able to influence the focus calls

rachelkang · 2023-02-17T01:05:38Z

@PureWeen In what scenario would someone call focus to a control that's already focused? And on the flipside, what might the repercussions be of letting someone focus on a control that's already focused? Only the risks come to mind at the moment

I'm not opposed to exposing it as a mapper though

github-actions · 2023-02-21T22:10:38Z

Thank you for your pull request. We are auto-formating your source code to follow our code guidelines.

rachelkang · 2023-02-21T22:44:10Z

src/Controls/src/Core/VisualElement.cs

@@ -799,7 +800,14 @@ public ResourceDictionary Resources
 		public bool Focus()
 		{
 			if (IsFocused)
+			{
+#if ANDROID
+				// TODO: Refactor using mappers for .NET 8


After chatting with @PureWeen, we've agreed to do this in a follow-up PR. While this code here isn't ideal, it keeps this PR backport-friendly

src/Controls/src/Core/VisualElement.cs

PureWeen · 2023-02-23T20:31:50Z

src/Controls/tests/DeviceTests/Elements/SearchBar/SearchBarTests.Android.cs

@@ -17,5 +18,28 @@ Task<string> GetPlatformText(SearchBarHandler handler)
 		{
 			return InvokeOnMainThreadAsync(() => GetPlatformControl(handler).Query);
 		}
+
+		[Fact]
+		public async Task ShowsKeyboardOnFocus()


Can we move these to a general test class so we don't have this code copied around?

I think we can create a TextInput set of tests

\TextInput\TextInput.Android.cs

Then you can use a theory with classdata to pass in all the textinput types.

github-actions · 2023-02-28T17:36:04Z

Thank you for your pull request. We are auto-formating your source code to follow our code guidelines.

This reverts commit 54addf0.

PureWeen · 2023-03-07T18:09:42Z

src/Core/src/Platform/Android/KeyboardManager.cs


-				var windowToken = inputView.WindowToken;
-				if (windowToken != null && inputMethodManager != null)
+			using (var inputMethodManager = (InputMethodManager)context.GetSystemService(Context.InputMethodService)!)


Can we remove the null forgiveness operator here? !

PureWeen · 2023-03-07T18:10:31Z

src/Core/src/Platform/Android/KeyboardManager.cs

-			{
-				// Cannot find the TextView; nothing else to do
-				return;
-			}

 			using (var inputMethodManager = (InputMethodManager)searchView.Context.GetSystemService(Context.InputMethodService)!)


Remove ! here as well? You might have to grab the service before the using and check it for null.

github-actions · 2023-03-08T16:02:57Z

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

PureWeen · 2023-03-09T15:56:10Z

/backport to net7.0

github-actions · 2023-03-09T15:56:25Z

Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/4376306063

github-actions · 2023-03-09T15:56:42Z

@PureWeen backporting to net7.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Show keyboard on Android entry/editor/searchbar focus
Applying: Move logic to mappers
Applying: Tweak Keyboard logic
Applying: Show keyboard on Android entry/editor/searchbar focus
Applying: Revert "Show keyboard on Android entry/editor/searchbar focus"
Applying: Small tweaks
Applying: Refactor UpdateFocus code into ViewExtensions
Applying: Add tests
Using index info to reconstruct a base tree...
M	src/Controls/tests/DeviceTests/Elements/Editor/EditorTests.Android.cs
M	src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.Android.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.Android.cs
CONFLICT (content): Merge conflict in src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.Android.cs
Auto-merging src/Controls/tests/DeviceTests/Elements/Editor/EditorTests.Android.cs
CONFLICT (content): Merge conflict in src/Controls/tests/DeviceTests/Elements/Editor/EditorTests.Android.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0008 Add tests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

github-actions · 2023-03-09T15:56:43Z

@PureWeen an error occurred while backporting to net7.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

Show keyboard on Android entry/editor/searchbar focus  Fixes #5983

This reverts commit 20f54bc, reversing changes made to a775a2d.

…" (#13874) This reverts commit 20f54bc, reversing changes made to a775a2d.

rachelkang requested a review from PureWeen January 24, 2023 19:22

Eilon added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jan 24, 2023

mandel-macaque reviewed Feb 7, 2023

View reviewed changes

src/Core/src/Handlers/Editor/EditorHandler.Android.cs Outdated Show resolved Hide resolved

rachelkang force-pushed the show-keyboard-on-android-focus branch from e7464bf to 54addf0 Compare February 7, 2023 20:08

rachelkang requested a review from mandel-macaque February 7, 2023 20:36

rachelkang marked this pull request as ready for review February 7, 2023 20:36

PureWeen requested changes Feb 7, 2023

View reviewed changes

src/Core/src/Handlers/SearchBar/SearchBarHandler.Android.cs Outdated Show resolved Hide resolved

rachelkang requested a review from PureWeen February 15, 2023 16:05

rachelkang mentioned this pull request Feb 15, 2023

[Bug] Keyboard Bugs and Xamarin.Forms migration concerns #11703

Closed

16 tasks

PureWeen requested changes Feb 15, 2023

View reviewed changes

src/Controls/tests/DeviceTests/Elements/Editor/EditorTests.Android.cs Outdated Show resolved Hide resolved

rachelkang requested a review from PureWeen February 16, 2023 21:47

PureWeen requested changes Feb 16, 2023

View reviewed changes

src/Core/src/Platform/Android/KeyboardManager.cs Show resolved Hide resolved

PureWeen requested changes Feb 17, 2023

View reviewed changes

rachelkang commented Feb 21, 2023

View reviewed changes

rachelkang requested a review from PureWeen February 21, 2023 22:44

PureWeen requested changes Feb 23, 2023

View reviewed changes

src/Controls/src/Core/VisualElement.cs Outdated Show resolved Hide resolved

rachelkang requested a review from PureWeen February 23, 2023 18:18

PureWeen requested changes Feb 23, 2023

View reviewed changes

rachelkang requested a review from PureWeen February 28, 2023 17:26

rachelkang added 7 commits March 1, 2023 13:33

Show keyboard on Android entry/editor/searchbar focus

57dfc02

Move logic to mappers

b51f533

Tweak Keyboard logic

8a6e2a7

Show keyboard on Android entry/editor/searchbar focus

ca7b39f

Revert "Show keyboard on Android entry/editor/searchbar focus"

0a98d7a

This reverts commit 54addf0.

Small tweaks

e296d82

Refactor UpdateFocus code into ViewExtensions

3e26d2e

PureWeen requested changes Mar 7, 2023

View reviewed changes

rachelkang and others added 4 commits March 7, 2023 14:14

Use as instead of !

904b1cc

Increase focus timeout

4cf055e

Make keyboard tests more debuggable

8f6d3f3

Auto-format source code

02b4889

Tweak exceptions

871b477

PureWeen approved these changes Mar 9, 2023

View reviewed changes

PureWeen merged commit 20f54bc into main Mar 9, 2023

PureWeen deleted the show-keyboard-on-android-focus branch March 9, 2023 14:39

PureWeen added the backport/suggested The PR author or issue review has suggested that the change should be backported. label Mar 9, 2023

PureWeen added the backport/approved After some discussion or review, this PR or change was approved to be backported. label Mar 9, 2023

rachelkang restored the show-keyboard-on-android-focus branch March 9, 2023 16:06

This was referenced Mar 9, 2023

[net7.0] Show keyboard on Android entry/editor/searchbar focus #13799

Closed

Refactor keyboard focus code for .NET 8 #13824

Merged

rachelkang added a commit that referenced this pull request Mar 13, 2023

Revert "Show keyboard on Android entry/editor/searchbar focus (#12890)"

9fb0475

This reverts commit 20f54bc, reversing changes made to a775a2d.

rachelkang mentioned this pull request Mar 13, 2023

Revert "Show keyboard on Android entry/editor/searchbar focus (#12890)" #13874

Merged

PureWeen pushed a commit that referenced this pull request Mar 14, 2023

Revert "Show keyboard on Android entry/editor/searchbar focus (#12890)…

d49140c

…" (#13874) This reverts commit 20f54bc, reversing changes made to a775a2d.

rachelkang mentioned this pull request Mar 14, 2023

Show keyboard on Android entry/editor/searchbar focus #13908

Merged

samhouts deleted the show-keyboard-on-android-focus branch July 28, 2023 19:48

github-actions bot locked and limited conversation to collaborators Dec 14, 2023

samhouts added area-controls-editor Editor platform/android 🤖 labels Jan 31, 2024

Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024

samhouts added the fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! label Aug 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show keyboard on Android entry/editor/searchbar focus #12890

Show keyboard on Android entry/editor/searchbar focus #12890

rachelkang commented Jan 24, 2023 •

edited

Loading

github-actions bot commented Feb 15, 2023

PureWeen left a comment

rachelkang commented Feb 17, 2023

github-actions bot commented Feb 21, 2023

rachelkang Feb 21, 2023 •

edited

Loading

PureWeen Feb 23, 2023

github-actions bot commented Feb 28, 2023

PureWeen Mar 7, 2023

PureWeen Mar 7, 2023

github-actions bot commented Mar 8, 2023

PureWeen commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

Show keyboard on Android entry/editor/searchbar focus #12890

Show keyboard on Android entry/editor/searchbar focus #12890

Conversation

rachelkang commented Jan 24, 2023 • edited Loading

Description of Change

Issues Fixed

github-actions bot commented Feb 15, 2023

⚠️ Your code has been reformatted. ⚠️

PureWeen left a comment

Choose a reason for hiding this comment

rachelkang commented Feb 17, 2023

github-actions bot commented Feb 21, 2023

rachelkang Feb 21, 2023 • edited Loading

Choose a reason for hiding this comment

PureWeen Feb 23, 2023

Choose a reason for hiding this comment

github-actions bot commented Feb 28, 2023

PureWeen Mar 7, 2023

Choose a reason for hiding this comment

PureWeen Mar 7, 2023

Choose a reason for hiding this comment

github-actions bot commented Mar 8, 2023

PureWeen commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

github-actions bot commented Mar 9, 2023

rachelkang commented Jan 24, 2023 •

edited

Loading

rachelkang Feb 21, 2023 •

edited

Loading