[Windows] Fix Border corners clipping issue #14403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
ghost
added
the
legacy-area-controls
mandel-macaque
approved these changes
Apr 5, 2023
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch.
|
@hartez Could I have your feedback here?. Thanks! |
hartez
previously requested changes
May 10, 2023
rmarinho
requested changes
Jun 19, 2023
| UpdateClip(borderShape); | ||
| } | ||
|
|
||
| internal void UpdateBorderStroke(IBorderStroke borderStroke) |
There was a problem hiding this comment.
I think this can be public on net8 no @hartez ? or else the Obsolete comment will not make sense since this is internal users can't call it
rmarinho
requested changes
Jun 22, 2023
There was a problem hiding this comment.
I was testing the gallery and seems some calculations are still wrong when we have content inside, we can see this using the gallery
-Go to the Border Playground
- Set Border Shape as Rectangle
- Set a solid Border
- Increase the Border Width to around 15
- You can see the text gets clipped
here's how it looks on Android, seems ok:
Reviewed and you are right. Without this PR changes can still reproduce it, so you have found a different issue. Will try to solve the issue in this same PR, and if require a bug amount of changes will open a new issue with a different associated PR. |
|
Applied changes to fix the issue detected by Rui: |
|
Added device tests: |
rmarinho
approved these changes
Jul 28, 2023
rmarinho
added a commit
that referenced
this pull request
Aug 3, 2023
* [create-pull-request] automated change (#16413) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Windows] Fix Border corners clipping issue (#14403) * Fix Border corners clipping mistake on Windows * Updated impl * Created method to avoid duplicated code * Revert uneccesary changes * Changes in clipping sizing * Fix Rui issue * Added device tests * Remove unnecessary changes --------- Co-authored-by: Javier Suárez <[email protected]> * Add ViewHandler Mapper docs (#16296) Co-authored-by: Juan Diego Herrera <[email protected]> * [create-pull-request] automated change (#16427) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix device tests to tun on arm64 (#16408) * Build on arm64 * magic * Only install on Arm64 machines * cleanup demands on the pipeline and add windows parameter * Print system arch * Fix getting OSArchitecture --------- Co-authored-by: Rui Marinho <[email protected]> * [uitests] Fix appium script (#16451) * Bump node version * Add more info to install script * Try clean modules before install * Uninstall before install * fix * Cleanup yaml * Write output of drivers * Try remove plugins before uninstall * [iOS] Fix Editor placeholder issues (#15883) * Fix iOS Editor placeholder size, characterspacing and fontsize issues * Added Device Test * Invalidate CharacterSpacing updating the placeholder * Updated Impl * [Essentials] Make PublisherName public on NET8 (#16454) * Fix EntryCellRenderer to use fromhandler for text changes (#16458) * [compatibility] Skip test on iOS (#16452) * [iOS] Re-enable editor tests (#16365) * Re-enable editor tests on iOS * Fix merge problem * [build] Remove the old step for vs insertion on release (#16457) * Reinstate IContentView and ILayout methods (#16411) * Reinstate IContentView and ILayout methods Fixes #16166 * Limit fake methods to NET Standard 2.0 * Reverse the polarity * Simplify * Work around compatibility implementations of ICV/ICPL methods on ScrollView * Use correct interface for Frame * [net8.0] Don't move to use arm yet here * [net8.0] Make UpdateBackground public (#16453) * [api] Make UpdateBackground public * Keep extensions internal * Fix issue setting ContentPage gradient background on iOS/Catalyst (#15832) * Fix provisioning script * [provisioning] Set Xcode path correctly for Xamarin Hosting --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Javier Suárez <[email protected]> Co-authored-by: Matthew Leibowitz <[email protected]> Co-authored-by: Juan Diego Herrera <[email protected]> Co-authored-by: Shane Neuville <[email protected]> Co-authored-by: E.Z. Hart <[email protected]>
Eilon
removed
the
legacy-area-controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix Border corners clipping mistake on Windows. Checking x I realized that the changes applied in #10964 in Android and iOS were not in Windows.
We was clipping using the Border shape. That is correct in many cases but not always. Using a RoundRectangle, the Corner Radius value is not the same in the inner or outer. We want in this case user the inner value.
Before
Notice the internal white space between the content and the border.
After
Fix #9129