[android] MauiTextView doesn't need ViewAttachedToWindow #14833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#12130 Context: https://github.com/angelru/CvSlowJittering Profiling a customer sample, I noticed that ~2.4% of of the time was spent subscribing to `ViewAttachedToWindow`: 278.55ms (2.4%) mono.android!Android.Views.View.add_ViewAttachedToWindow(System.EventHandler`1<Android.Views.View/ViewAttachedToWindowEv It appeared that for every `Label` on Android, we setup this event. Additionally, Java would have to call into C# when the event fires: 30.55ms (0.26%) mono.android!Android.Views.View.IOnAttachStateChangeListenerInvoker.n_OnViewAttachedToWindow_Landroid_view_View__mm_wra However, we don't actually *do* anything in the event (added in b6c3b53), so we should be able to just delete it? this.ViewAttachedToWindow += MauiTextView_ViewAttachedToWindow; //... private void MauiTextView_ViewAttachedToWindow(object? sender, ViewAttachedToWindowEventArgs e) { } Doing this, dropped the call to ~0.02%: 2.76ms (0.02%) mono.android!Android.Views.View.add_ViewAttachedToWindow(System.EventHandler`1<Android.Views.View/ViewAttachedToWindowEv And the above `IOnAttachStateChangeListenerInvoker` call is gone completely. This should improve the performance of every `Label` on Android.
ghost
added
the
legacy-area-controls
jsuarezruiz
approved these changes
Apr 28, 2023
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Eilon
added
t/perf
samhouts
added
the
fixed-in-8.0.0-preview.4.8333
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #12130
Context: https://github.com/angelru/CvSlowJittering
Profiling a customer sample, I noticed that ~2.4% of of the time was spent subscribing to
ViewAttachedToWindow:It appeared that for every
Labelon Android, we setup this event. Additionally, Java would have to call into C# when the event fires:However, we don't actually do anything in the event (added in b6c3b53), so we should be able to just delete it?
Doing this, dropped the call to ~0.02%:
And the above
IOnAttachStateChangeListenerInvokercall is gone completely.This should improve the performance of every
Labelon Android.