Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GotoAsync overload for single use query parameters #15585

Merged
merged 8 commits into from
Jul 13, 2023

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Jun 12, 2023

Description of Change

Alternate PR from
#15281
#14965

Examples for the docs to improve clarity

We should enhance the navigation part of the Shell docs to include various example permutations of how parameters are handled.

Still works the same

await GotoAsync("firstPage?param=1");
await GotoAsync("nextPage");
await GotoAsync(".."); // param = 1 will get applied to `firstPage`

New

ComplexObject obj;
var params = new ShellNavigationQueryParameters()
{
    {"field", obj}
}

await GotoAsync("firstPage?param=1", params);
await GotoAsync("nextPage");
await GotoAsync(".."); // param = 1 will get applied to `firstPage` but `ComplexObject` won't

Issues Fixed

Fixes #10294

@PureWeen PureWeen requested review from hartez and mattleibow June 12, 2023 16:45
@Eilon Eilon added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label Jun 15, 2023
@PureWeen PureWeen force-pushed the single_use_query_parameter branch from e05faf3 to 53ee22c Compare June 27, 2023 23:02
@PureWeen PureWeen force-pushed the single_use_query_parameter branch from 53ee22c to 5e0aec3 Compare June 30, 2023 00:15
@PureWeen PureWeen marked this pull request as ready for review July 4, 2023 07:45
@PureWeen PureWeen marked this pull request as draft July 4, 2023 18:11
@PureWeen PureWeen marked this pull request as ready for review July 5, 2023 17:01
@PureWeen PureWeen merged commit 432caf1 into main Jul 13, 2023
@PureWeen PureWeen deleted the single_use_query_parameter branch July 13, 2023 01:59
@samhouts samhouts added the backport/suggested The PR author or issue review has suggested that the change should be backported. label Jul 28, 2023
@PureWeen PureWeen added the backport/NO This change should not be backported. It may break customers. label Aug 2, 2023
@PureWeen
Copy link
Member Author

PureWeen commented Aug 2, 2023

This adds a new API. We can't backport new APIs to net7.0.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.7.8842 Look for this fix in 8.0.0-preview.7.8842! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout backport/NO This change should not be backported. It may break customers. backport/suggested The PR author or issue review has suggested that the change should be backported. fixed-in-8.0.0-preview.7.8842 Look for this fix in 8.0.0-preview.7.8842!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation data is retained and also presented to IQueryAttributable on Back navigation.
5 participants