-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include headers/footers in EmptySource count so they show up when ItemsSource is null #15979
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some additional tests that would cover the case(s) found by the legacy gallery?
/rebase |
I see the less correct #15688 is merged... yuet no conflicts even since it touches the same files... |
…msSource is null Fixes #8934
6022c81
to
4cd5c23
Compare
I see it was reverted actually: #15886 This is the issue that Shane was referring to: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7979402&view=ms.vss-test-web.build-test-results-tab ![]() |
Aren't they covered by the legacy gallery tests? |
We only run these tests on the main/feature branches. Ideally, we'll grow enough coverage inside our new appium tests/device tests (which run on every PR) that we can eventually just obsolete our legacy gallery tests once we feel that we've pretty much reached coverage parity. |
Description of Change
The EmptySource on Android is aware of the header and footer, but doesn't include them in the
Count
. Which means that the adapters don't know to display them when the ItemSource isnull
.This change adjusts the reported
Count
from EmptySource to account for the presence of the header and footer.This is an alternate (and more correct) solution to #15688.
Issues Fixed
Fixes #8934