Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue using LineBreakMode and MaxLines at the same time #5093

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Fix issue using LineBreakMode and MaxLines at the same time #5093

merged 2 commits into from
Mar 23, 2022

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Mar 7, 2022 •
edited
Loading

Description of Change

Fix issue using LineBreakMode and MaxLines at the same time. MaxLines value is incorrect in this case.

image

Issues Fixed

Fixes #4805

@jsuarezruiz jsuarezruiz added t/bug Something isn't working area-controls-label Label, Span labels Mar 7, 2022
@Eilon Eilon added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Mar 7, 2022
@Redth Redth requested a review from PureWeen March 8, 2022 02:33
@Redth Redth added this to the 6.0.300-rc.1 milestone Mar 21, 2022
@Redth Redth self-requested a review March 22, 2022 18:46
@Redth Redth assigned Redth and unassigned jsuarezruiz Mar 22, 2022
@Redth Redth merged commit f46f5c9 into main Mar 23, 2022
@Redth Redth deleted the fix-4805 branch March 23, 2022 19:25
@ram16g ram16g mentioned this pull request Apr 13, 2022
Closed
@vcechak vcechak mentioned this pull request Mar 22, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Redth Redth Redth approved these changes

@PureWeen PureWeen Awaiting requested review from PureWeen

Assignees

@Redth Redth

Labels
area-controls-label Label, Span fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1! t/bug Something isn't working
Projects
None yet
Milestone
6.0.300-rc.1
Development

Successfully merging this pull request may close these issues.

Label MaxLines doesn't work
4 participants
@jsuarezruiz @Redth @Eilon @samhouts