Don't clear images to avoid Glide not loading images #6543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
added
t/bug
Redth
approved these changes
Apr 27, 2022
Eilon
added
area-controls-image
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Calling
requestManager.clear(target)before loading a new image somehow causes Glide to not actually load images.This PR removes the clear calls and then relies on the fact that loading a new image will clear out the old one and release it:
https://bumptech.github.io/glide/doc/targets.html#cancellation-and-re-use
I did the fix in java code as that is where I believe the issue is. Rather have all the code set up for disposal in the managed world and all the events fire as expected.
Issues Fixed
Fixes #6464