Don't clear old images. Fixes #6625 #7348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
added
area-image
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Redth
approved these changes
May 24, 2022
This was referenced Dec 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is basically because the idea of clearing an image before loading the next one is flawed. It is technically correct, make sure all is gone before starting on the new.
However, from a UX perspective, this is terrible. When switching out an image, there is one constant in this world and that is nothing is constant. Namely the internet is not fast enough to download and the device is not fast enough to decode and cache before the user notices. As a result, until all this is done, the image vanishes and this is not pleasing.
This PR basically solves all the issues (and acts like the underlying platforms) by literally doing less. And that is more.
Issues Fixed
Fixes #6625