Fix the sample build #8751
Merged
Fix the sample build #8751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sample build is secretly building maui! This is because the sample sln contains the foldable project - which is a library that references all of maui.
|
This will remove a warning in #6871 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
samhouts
added
fixed-in-7.0.0-rc.1.6683
fixed-in-6.0.486
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The sample build is secretly building maui! This is because the sample sln contains the foldable project - which is a library that references all of maui.
This PR marks the Foldable project as a "sample-able" project and excludes the maui project references when building the samples. It also moves all the package references in the "Microsoft.Maui.Controls.MultiTargeting.targets" file into the Core project as this is where it is needed. This makes Essentials no longer depend on things it does not need.