Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetLogicalProject() doesn't return elements imported from Sdks #1570

Closed
rainersigwald opened this issue Jan 13, 2017 · 1 comment
Closed

GetLogicalProject() doesn't return elements imported from Sdks #1570

rainersigwald opened this issue Jan 13, 2017 · 1 comment
Labels
triaged
Milestone
MSBuild 15.1 RC.3

Comments

@rainersigwald
Copy link
Member

Call Microsoft.Build.Evaluation.Project.GetLogicalProject() on a project that uses the new Sdk feature. After #1492 the results contain only the elements within the top-level project and don't include projects imported by the Sdk.
@rainersigwald rainersigwald added this to the MSBuild 15.1 RC.3 milestone Jan 13, 2017
This was referenced Jan 13, 2017
Closed
Closed
@jeffkl jeffkl mentioned this issue Jan 13, 2017
Merged
rainersigwald pushed a commit that referenced this issue Jan 13, 2017
@jeffkl @rainersigwald
Include implicit imports in GetLogicalProject() (#1571)
dddc68c 
Closes #1570
@srivatsn srivatsn mentioned this issue Jan 14, 2017
Closed
@rainersigwald rainersigwald mentioned this issue Jan 14, 2017
Merged
@rainersigwald
Copy link
Member Author

This is fixed and inserted into VS.

@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triaged
Projects
None yet
Milestone
MSBuild 15.1 RC.3
Development

No branches or pull requests
3 participants
@rainersigwald @jeffkl @AR-May