Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DesignTimeBuild restriction #10732

Merged

Conversation

YuliiaKovalova
Copy link
Member

@YuliiaKovalova YuliiaKovalova commented Sep 30, 2024

It's related to adding a new target import: #10698
VS doesn't always emit "DesignTimeBuild" flag that cause an issue with importing for some cases (e.g. project load from UI).

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I'm wondering if there is a relaible way how to import this only if we are executing build from VS. I put a suggestion into comments

src/Tasks/Microsoft.CSharp.CurrentVersion.targets Outdated Show resolved Hide resolved
@YuliiaKovalova YuliiaKovalova merged commit 37c8fdb into dotnet:main Sep 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants