Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-quote Exec command line on *nix #2467

Merged
merged 1 commit into from
Aug 24, 2017

Conversation

rainersigwald
Copy link
Member

Triple-quotes seem to have been expanded as
{empty quoted string}{single-quoted string}{empty quoted string}
rather than special
escaping. That confused an updated version of System.Diagnostic.Process,
so simplifying the quoting.

See https://github.com/dotnet/corefx/issues/23496#issuecomment-324519381 for context.

Triple-quotes seem to have been expanded as {empty quoted
string}{single-quoted string}{empty quoted string} rather than special
escaping. That confused an updated version of System.Diagnostic.Process,
so simplifying the quoting.
@eerhardt
Copy link
Member

Thanks @rainersigwald for the quick fix.

@nguerrera @dsplaisted - if we take the MSBuild build with this fix into dotnet/cli, we should be able to enable Exec on .NET Core 2.1 again. I'm assuming it will be faster to get a new MSBuild build, than it will be to wait for the fix in CoreFX.

@nguerrera
Copy link
Contributor

Works for me. Thanks!

@rainersigwald
Copy link
Member Author

@eerhardt @nguerrera Are y'all ok with taking an MSBuild 15.5? I asked @dsplaisted about that yesterday and wasn't sure if it was ok to do so.

(No breaking changes, but some changes that are slightly higher risk. We want to move forward but don't want to drag y'all around unnecessarily.)

@nguerrera
Copy link
Contributor

This would go to master which is actually post 15.5 so no worries there.

@rainersigwald
Copy link
Member Author

👍 I'll build + publish a package as soon as someone else on my team gets to work and approves this.

@rainersigwald rainersigwald merged commit 1640b24 into dotnet:master Aug 24, 2017
@rainersigwald rainersigwald deleted the single-quote-exec branch August 24, 2017 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants